Add devtools tests #258
Closed
Add devtools tests #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
For this, I will need to write a custom script in devtools to run the tests. I will follow up on this tomorrow |
7 tasks
| @@ -0,0 +1,12 @@ | |||
| # Tests from https://github.com/flutter/devtools | |||
|
|
|||
| contact=kenzieschmoll@google.com | |||
Member
There was a problem hiding this comment.
Is this typically a single person or a google group? If it does need a primary POC then that is fine to be me but can we add a secondary contact dart-devtools-eng@google.com?
Contributor
Author
There was a problem hiding this comment.
Definitely, I'll update this.
kenzieschmoll
approved these changes
May 15, 2023
Contributor
Author
|
Hmm... Looks like a bunch of tests are timing out. and not all of the expected mocks are created by the generate script. |
Contributor
Author
|
Closing since the devtools tests aren't working in this environment as expected right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the flutter/devtools test suite for checking against changes in flutter/flutter
Fixes flutter/devtools#4433
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.