Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@lschmierer
Copy link

Audio permission is not required if sb. want to take pictures only. This change introduces a parameter in CameraController to enable/disable video support.

On iOS, no changes were needed since iOS asks for permission only once video is actually recorded.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot
Copy link

CLAs look good, thanks!

@collinjackson collinjackson added feature submit queue The Flutter team is in the process of landing this PR. and removed submit queue The Flutter team is in the process of landing this PR. labels Dec 12, 2018
@collinjackson collinjackson removed the submit queue The Flutter team is in the process of landing this PR. label Dec 12, 2018
@matin
Copy link

matin commented Dec 26, 2018

@amirh would you be able to review this PR? At the moment, Android users have to authorize microphone permissions just to take photos. It's a confusing experience.

@cyanglaz cyanglaz changed the title Camera: Optional audio permission on android [camera]Camera: Optional audio permission on android Feb 22, 2019
@bparrishMines
Copy link
Contributor

Hi @lschmierer

Thanks for the contribution and sorry for the delay! This feature is now implemented with #837 in version 0.5.2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants