Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@gisdatasrl
Copy link

Enclosed AVCaptureDeviceDiscoverySession in a @availabe check and managed older versions with the older versions with the older api

Fixes flutter/flutter#20708

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@gisdatasrl
Copy link
Author

I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Oct 1, 2018
Enclosed **AVCaptureDeviceDiscoverySession** in a @availabe check and managed older versions with the older versions with the older api

Fixes flutter/flutter#20708
@hariprasadiit
Copy link

this won't work as the changes are not handling other iOS 10+ only like AVCapturePhotoOutput

@Hixie
Copy link
Contributor

Hixie commented Mar 31, 2020

I'm going through some old PRs to see what we can do with them. First, sorry for dropping this on the floor, we do appreciate your contributions though apparently we don't do a good job of showing it.

For this PR specifically, I'm going to close it because it is lacking tests and all our PRs need to have tests.

@Hixie Hixie closed this Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

plugin: camera - crashes on iOS < 10

5 participants