fix typo in setCookieForInsances method and update CHANGELOG.md
#6288
Conversation
Losing all of the context of previous reviews doesn't reduce confusion; is there a technical issue with just updating the existing PR? |
|
What's the status of this? #6102 merged, but it was empty? |
I still can't figure out what happened to that PR; the commit hash it lists isn't for that PR. And it says @kosukesaigusa did the merging into |
|
Regardless, at this point we should just re-review in this new PR. |
| * Fixes avoid_redundant_argument_values lint warnings and minor typos. | ||
| * Ignores unnecessary import warnings in preparation for [upcoming Flutter changes](https://github.com/flutter/flutter/pull/104231). | ||
| * Updates references to the obsolete master branch. | ||
| * Fixes typo in a method name, from `setCookieForInsances` to `setCookieForInstances`. |
There was a problem hiding this comment.
This needs to be a version change, not a NEXT, per repo policy.
|
@kosukesaigusa Since this is still waiting on updates, I went ahead and created #6384 with the updated version bump. Closing in favor of #6384 |
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.