[in_app_purchase] Add IMMEDIATE_AND_CHARGE_FULL_PRICE to ProrationMode #6132
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Thanks for the contribution! You’ve checked boxes in the PR checklist above that are not reflected in this PR, so I’m assuming this is a work in progress and am marking it as a Draft. Please review the checklist, updating the PR as appropriate, and when the checklist reflects the state of the PR as posted please feel free to mark it as ready for review. |
|
@stuartmorgan ProrationMode is mapped to Int by JsonSerializable. |
As it says in the automated response text above:
Would it matter to you if this enum value were accidentally dropped in a later update? Or if the value were accidentally changed to something other than 5 such that it didn't work correctly? |
Added IMMEDIATE_AND_CHARGE_FULL_PRICE to ProrationMode.
IMMEDIATE_AND_CHARGE_FULL_PRICE is new in Billing Library v4.
https://developer.android.com/google/play/billing/release-notes#4-0-0-summary-changes
This library has already been updated to v5, so there is no problem.
Fixes flutter/flutter#108164
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.