This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[Camera] Change from AVFileTypeQuickTimeMovie to AVFileTypeMPEG4 #1525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @hillelcoren, I agree that it makes sense that they should return the same file type. However, this could be a breaking change for any user expecting |
Member
Author
|
Awesome, thanks! I'll close the PR to reduce clutter, look forward to seeing this as an option. |
|
big irony, i was hoping it would be the same as android :P im going to be forking @hillelcoren version and will try to keep it up to date, i need that |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently videos captured on Android are .mp4 whereas videos captured on iOS are .qt. This PR modifies the behavior on iOS to match Android capturing videos as .mp4. For our app (and I would imagine others) it's much better for us to have one type of video file for all users.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?