Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@tungvn
Copy link

@tungvn tungvn commented Jan 8, 2019

This PR support flash mode (off, on, auto) on each time take pictures

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@tungvn
Copy link
Author

tungvn commented Jan 8, 2019

I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@tungvn
Copy link
Author

tungvn commented Jan 8, 2019

I signed it!

@tungvn
Copy link
Author

tungvn commented Jan 8, 2019

Well. Someone helps me the CLA configs, please!

@cyanglaz cyanglaz changed the title Support flash on taking pictures [camera]Support flash on taking pictures Feb 22, 2019
@callumclift
Copy link

callumclift commented Mar 4, 2019

@tungvn i've tried to implement your changes but the flash is still not working consistently, i've got it to work on a Samsung device however the flash is not working on a Google Pixel 2 XL. Would you possibly be able to assist me in getting it to work?

@tungvn
Copy link
Author

tungvn commented Mar 5, 2019

@tungvn i've tried to implement your changes but the flash is still not working consistently, i've got it to work on a Samsung device however the flash is not working on a Google Pixel 2 XL. Would you possibly be able to assist me in getting it to work?

Yes. Now I test on a Samsung Note 9, it is also not working. I am not a native coder and I am stuck for fixing this issue.

@MartinHlavna
Copy link

I would also appreciate this feature.

@lambasoft
Copy link

I would really appreciate this feature. Currently there is no way to turn on flash while using the camera plugin?

@tungvn
Copy link
Author

tungvn commented Jun 3, 2019

I would really appreciate this feature. Currently there is no way to turn on flash while using the camera plugin?

I test this PR on iOS and some Android devices, it worked. But it has some issues on Samsung devices and I am trying to fix it.

@tungvn tungvn closed this Jun 19, 2019
@MartinHlavna
Copy link

Is this merged?

@jovinho
Copy link

jovinho commented Nov 12, 2019

Looking foward to it

@clipsmm
Copy link

clipsmm commented Nov 30, 2019

Please add this asap

@Ahmadre
Copy link

Ahmadre commented Dec 30, 2019

@tungvn why did you close your PR? I got a similar implementation and its working on Pixel 2XL (besides I got a Pixel 2 XL). If you like I can request a PR

@gisinator
Copy link

Go for it, flash functionality is being highly demanded :)

@clipsmm
Copy link

clipsmm commented Jan 17, 2020

@tungvn why did you close your PR? I got a similar implementation and its working on Pixel 2XL (besides I got a Pixel 2 XL). If you like I can request a PR

How did you get this to work?

@morbyosef
Copy link

What is the status of this feature? Very important feature :/

@GustavoFigueira
Copy link

March, 2020. We still need this future! Use flash/torch is a essential feature for a camera package like this! Please merge this PR.

@sosuren
Copy link

sosuren commented Apr 21, 2020

Flash/torch is a essential feature for a camera package like this! Please give this a priority

@Hellomik2002
Copy link

We still need it

@fekitibi
Copy link

I hope this feature will be implemented soon.

@paulewetzel
Copy link

I need this feature too for a project I am working on right now.

@felipesses
Copy link

i also need this feature!

@dinanjanan
Copy link

Anyone who reaches this page, this issue has been solved now. New features to the camera plugin are no longer being added, but there is a third-party plugin called 'camerawesome'. Do check it out! It has all the features the camera plugin couldn't incorporate (well, almost)!

https://pub.dev/packages/camerawesome

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.