-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[camera]Support flash on taking pictures #1047
Conversation
Support flash on taking picture
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
I signed it! |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
|
I signed it! |
|
Well. Someone helps me the CLA configs, please! |
|
@tungvn i've tried to implement your changes but the flash is still not working consistently, i've got it to work on a Samsung device however the flash is not working on a Google Pixel 2 XL. Would you possibly be able to assist me in getting it to work? |
Yes. Now I test on a Samsung Note 9, it is also not working. I am not a native coder and I am stuck for fixing this issue. |
|
I would also appreciate this feature. |
|
I would really appreciate this feature. Currently there is no way to turn on flash while using the camera plugin? |
I test this PR on iOS and some Android devices, it worked. But it has some issues on Samsung devices and I am trying to fix it. |
|
Is this merged? |
|
Looking foward to it |
|
Please add this asap |
|
@tungvn why did you close your PR? I got a similar implementation and its working on Pixel 2XL (besides I got a Pixel 2 XL). If you like I can request a PR |
|
Go for it, flash functionality is being highly demanded :) |
How did you get this to work? |
|
What is the status of this feature? Very important feature :/ |
|
March, 2020. We still need this future! Use flash/torch is a essential feature for a camera package like this! Please merge this PR. |
|
Flash/torch is a essential feature for a camera package like this! Please give this a priority |
|
We still need it |
|
I hope this feature will be implemented soon. |
|
I need this feature too for a project I am working on right now. |
|
i also need this feature! |
|
Anyone who reaches this page, this issue has been solved now. New features to the camera plugin are no longer being added, but there is a third-party plugin called 'camerawesome'. Do check it out! It has all the features the camera plugin couldn't incorporate (well, almost)! |
This PR support flash mode (off, on, auto) on each time take pictures