Skip to content

[quick_actions] add localizedSubtitle for iOS #8038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 24 commits into from
Dec 11, 2024
Merged

[quick_actions] add localizedSubtitle for iOS #8038

auto-submit merged 24 commits into from
Dec 11, 2024

Conversation

@sinyu1012
Copy link
Contributor

@sinyu1012 sinyu1012 commented Nov 8, 2024 •
edited by stuartmorgan-g
Loading

Add the localizedSubtitle field on quick actions for iOS

Fixes flutter/flutter#129759

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

GiacomoPignoni and others added 10 commits June 23, 2024 13:11
@GiacomoPignoni
[quick_actions] add localizedSubtitle for iOS
929fdea
@GiacomoPignoni
test and changelog
4bea2bc
@GiacomoPignoni
add deps override
fd8a73a
@GiacomoPignoni
update ios changelog
4cba4da
@GiacomoPignoni
update platform interface changelog
1886a75
@sinyu1012
Merge branch 'main' into quick_action/subtitle
3dd729f 
* main: (1187 commits)
  [various] Update example app minSdkVersions (flutter#8035)
  [go_router] Activate leak testing (flutter#7546)
  [in_app_purchase_storekit] Add restore purchases and receipts (flutter#7964)
  [interactive_media_ads] Adds remaining methods for internal wrapper of the Android native `BaseManager` (flutter#7943)
  [google_sign_in/google_identity_services] Clear-up documentation of callbacks in various APIs and uses of those APIs (flutter#8029)
  [flutter_svg] wasm compatibility (flutter#8014)
  Applied Gradle Plugins Declaratively for Multiple Plugin Example Apps (Part 2) (flutter#8019)
  Roll Flutter from 29d40f7 to 73546b3 (20 revisions) (flutter#8028)
  [ci] Upload screenshots, logs, and Xcode test results for drive and integration_test runs (flutter#7430)
  Remove use_modular_headers! from Podfiles (flutter#7796)
  [camera_avfoundation] enable more than 30 fps (flutter#7394)
  Roll Flutter from 8591d0c to 29d40f7 (25 revisions) (flutter#8027)
  [ci] Add vector_graphics and flutter_svg to autolabeler (flutter#8025)
  [vector_graphics_compiler] wasm compatibility (flutter#8021)
  [vector_graphics*] Relax dependency constraints of vector_graphics, vector_graphics_codec, vector_graphics_compiler, flutter_svg  (flutter#8018)
  [various] Add `missing_code_block_language_in_doc_comment` lint to flutter/packages. (flutter#6473)
  [various] Update example apps to Kotlin 1.9.0 (flutter#7998)
  [go_router] add current state getter (flutter#7651)
  Applied Gradle Plugins Declaratively for Multiple Plugin Example Apps (flutter#7968)
  Roll Flutter from f86b777 to 8591d0c (16 revisions) (flutter#8015)
  ...

# Conflicts:
#	packages/quick_actions/quick_actions/CHANGELOG.md
#	packages/quick_actions/quick_actions_ios/CHANGELOG.md
#	packages/quick_actions/quick_actions_platform_interface/CHANGELOG.md
@sinyu1012
update changelog
bf72048
@sinyu1012
revert quick_actions_android changes
a0ac67e
@sinyu1012
opt QuickActionsPlugin
ce569d9
@sinyu1012
update notes
2bf8256
@google-cla
Copy link

google-cla bot commented Nov 8, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@sinyu1012 sinyu1012 mentioned this pull request Nov 8, 2024
Closed
11 tasks
@sinyu1012 sinyu1012 changed the title Quick action/subtitle [quick_actions] add localizedSubtitle for iOS Nov 8, 2024
@stuartmorgan-g stuartmorgan-g added the triage-ios Should be looked at in iOS triage label Nov 8, 2024
@jmagman
Copy link
Member

jmagman commented Nov 13, 2024

Also, Mac_arm64 macos_repo_checks is showing a swift-format error:
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8731849849150109729/+/u/Run_package_tests/Swift_format/stdout

@sinyu1012
Copy link
Contributor Author

sinyu1012 commented Nov 13, 2024

Also, Mac_arm64 macos_repo_checks is showing a swift-format error: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8731849849150109729/+/u/Run_package_tests/Swift_format/stdout

Thanks，Please help review again.

jmagman
jmagman approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick_actions_ios part LGTM.

@stuartmorgan should I just remove the triage-ios label to kick it back to be reviewed for the federated interface part?

@jmagman jmagman removed the triage-ios Should be looked at in iOS triage label Nov 13, 2024
@stuartmorgan-g
Copy link
Collaborator

stuartmorgan-g commented Nov 13, 2024

@stuartmorgan should I just remove the triage-ios label to kick it back to be reviewed for the federated interface part?

We don't filter out by triage-* labels, so the other reviews should happen in parallel; you can just remove it once the iOS team doesn't expect to need to provide any further input on a PR.

@sinyu1012
Copy link
Contributor Author

sinyu1012 commented Nov 14, 2024

@stuartmorgan What do I need to do next?

@sinyu1012
Copy link
Contributor Author

sinyu1012 commented Nov 22, 2024

@stuartmorgan @bparrishMines @jmagman @camsim99

The prerequisite PR (#8112) for the platform interface has been merged. I have:

  1. Updated the dependencies to use the published version (^1.1.0) of quick_actions_platform_interface
  2. Removed all path-based dependency overrides
  3. Verified that all tests are passing

Could you please review this PR again? Thank you for your time!

stuartmorgan-g
stuartmorgan-g requested changes Nov 22, 2024
View reviewed changes
@sinyu1012 sinyu1012 mentioned this pull request Nov 22, 2024
Merged
11 tasks
@sinyu1012
Copy link
Contributor Author

sinyu1012 commented Dec 11, 2024

@stuartmorgan @bparrishMines @jmagman @camsim99

The prerequisite PR (#8149) for the ios package has been merged. Could you please review this PR again? Thank you for your time!

stuartmorgan-g
stuartmorgan-g approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 11, 2024
@flutter-dashboard
Copy link

flutter-dashboard bot commented Dec 11, 2024

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@auto-submit auto-submit bot merged commit 8238e1c into flutter:main Dec 11, 2024
77 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@jmagman jmagman jmagman approved these changes

@bparrishMines bparrishMines bparrishMines approved these changes

@camsim99 camsim99 Awaiting requested review from camsim99

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: quick_actions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[quick_actions] ios add option to use localizedSubtitle

5 participants

@sinyu1012 @jmagman @stuartmorgan-g @bparrishMines @GiacomoPignoni