Skip to content

[flutter_markdown] Fix tests for flutter/flutter#121112 #3693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Rexios80 wants to merge 2 commits into from
Closed

[flutter_markdown] Fix tests for flutter/flutter#121112 #3693

Rexios80 wants to merge 2 commits into from

Conversation

@Rexios80
Copy link
Member

@Rexios80 Rexios80 commented Apr 12, 2023 •
edited
Loading

PR flutter/flutter#121112 changes the structure of Flex widgets, so any tests expecting a certain widget structure with Row, Column, etc are failing.

The Flex type is no longer transparent, so this PR adds code to ignore it.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@Rexios80 Rexios80 requested a review from domesticmouse as a code owner April 12, 2023 14:03
@flutter-dashboard
Copy link

flutter-dashboard bot commented Apr 12, 2023

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@Rexios80 Rexios80 changed the title [flutter_markdown] Fix tests for https://github.com/flutter/flutter/pull/121112 [flutter_markdown] Fix tests for flutter/flutter#121112 Apr 12, 2023
@Rexios80 Rexios80 mentioned this pull request Apr 12, 2023
Closed
8 tasks
@Hixie
Copy link
Contributor

Hixie commented Apr 12, 2023

test-exempt: helps migration

(but I'm skeptical that the migration itself should land)

@Rexios80
Copy link
Member Author

Rexios80 commented Apr 13, 2023

Yeah, let's not

@Rexios80 Rexios80 closed this Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@domesticmouse domesticmouse Awaiting requested review from domesticmouse

Assignees

No one assigned

Labels

needs tests p: flutter_markdown

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Rexios80 @Hixie