[pigeon] Fix Kotlin generated sync host api error #2693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan-g
requested changes
Oct 10, 2022
Collaborator
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Thanks for the PR!
d718fc7 to
86ad230
Compare
tarrinneal
reviewed
Oct 12, 2022
Contributor
tarrinneal
left a comment
There was a problem hiding this comment.
This is a good fix, thank you for catching my error. I think this might point to an oversight in our e2e testing as well. I'll look into making that more robust.
Collaborator
|
What's the status of this PR? Is it ready for another review? |
Contributor
Author
yeah, Please. |
tarrinneal
approved these changes
Oct 28, 2022
stuartmorgan-g
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the kotlin code only reply when it catch the error.
this is the java generation code
fixes flutter/flutter#113187
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.