Skip to content

[go_router] Remove assert so that ShellRoute allows child ShellRoute #2625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 5 commits into from
Sep 21, 2022
Merged

[go_router] Remove assert so that ShellRoute allows child ShellRoute #2625

auto-submit merged 5 commits into from
Sep 21, 2022

Conversation

@johnpryan
Copy link
Contributor

@johnpryan johnpryan commented Sep 20, 2022

closes flutter/flutter#111981

See flutter/samples#1437 for an example use-case.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@johnpryan johnpryan requested a review from chunhtai September 20, 2022 18:32
@flutter-dashboard
Copy link

flutter-dashboard bot commented Sep 20, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@johnpryan johnpryan changed the title [go_router] Remove assert so that ShellRoute should allow child ShellRoute [go_router] Remove assert so that ShellRoute allows child ShellRoute Sep 20, 2022
chunhtai
chunhtai reviewed Sep 20, 2022
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM, would need a test though

chunhtai
chunhtai approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnpryan
Copy link
Contributor Author

johnpryan commented Sep 20, 2022

It looks like CI will fail until we fix flutter/flutter#111909

@chunhtai
Copy link
Contributor

chunhtai commented Sep 20, 2022

This should unblock it #2627

@chunhtai
Copy link
Contributor

chunhtai commented Sep 21, 2022

This should be able to merge now

@johnpryan johnpryan added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 21, 2022
@auto-submit auto-submit bot merged commit a9cd95c into flutter:main Sep 21, 2022
@johnpryan johnpryan deleted the remove-go-route-assert branch September 30, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loic-sharma loic-sharma loic-sharma approved these changes

@chunhtai chunhtai chunhtai approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: go_router

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[go_router] ShellRoute should allow child ShellRoute instances

3 participants

@johnpryan @chunhtai @loic-sharma