[cupertino_ui] Migrate bottom_tab_bar_test.dart to SemanticsHandle#12012
[cupertino_ui] Migrate bottom_tab_bar_test.dart to SemanticsHandle#12012Renzo-Olivares wants to merge 3 commits into
bottom_tab_bar_test.dart to SemanticsHandle#12012Conversation
There was a problem hiding this comment.
Code Review
This pull request unskips the bottom tab bar tests, migrates them from SemanticsTester to SemanticsHandle with isSemantics assertions, and adds a new image_data.dart helper file. The reviewer feedback recommends using addTearDown to ensure SemanticsHandle is safely disposed of even if tests fail, allowing the manual dispose calls to be removed.
|
|
||
| testWidgets('tabs announce semantics', (WidgetTester tester) async { | ||
| final semantics = SemanticsTester(tester); | ||
| final SemanticsHandle handle = tester.ensureSemantics(); |
There was a problem hiding this comment.
Using addTearDown(handle.dispose) immediately after creating the SemanticsHandle is a safer pattern. It ensures that the handle is properly disposed of even if the test fails or throws an exception, preventing leaks that could affect subsequent tests.
| final SemanticsHandle handle = tester.ensureSemantics(); | |
| final SemanticsHandle handle = tester.ensureSemantics(); | |
| addTearDown(handle.dispose); |
There was a problem hiding this comment.
This is how the test was previously structured, no addTearDown was previously used. Also explanation from gemini below as to why the test fails if we do use addTearDown(handle.dispose).
From gemini:
Flutter's TestWidgetsFlutterBinding runs its end-of-test leak verifications (specifically _verifySemanticsHandlesWereDisposed) inside the test body execution flow, immediately after your test callback completes, but before returning control to the Dart test runner:
1. [Test Runner] Starts test
2. [Flutter Binding] Runs test body (your async callback)
3. Your test code executes...
4. Your test code completes.
5. [Flutter Binding] Runs _endOfTestVerifications() <-- CRITICAL POINT
6. Checking active SemanticsHandles...
ERROR: "A SemanticsHandle was active at the end of the test."
7. [Test Runner] Runs addTearDown callbacks <-- TOO LATE!
8. handle.dispose() is called here.
Because the verification (Step 5) happens before the test runner runs the teardown callbacks (Step 7), the binding sees that the SemanticsHandle is still active and throws a FlutterError, failing the test.
| ); | ||
|
|
||
| semantics.dispose(); | ||
| handle.dispose(); |
There was a problem hiding this comment.
Since addTearDown(handle.dispose) is used to manage the lifecycle of the SemanticsHandle, this manual call to handle.dispose() can be removed.
There was a problem hiding this comment.
| WidgetTester tester, | ||
| ) async { | ||
| final semantics = SemanticsTester(tester); | ||
| final SemanticsHandle handle = tester.ensureSemantics(); |
There was a problem hiding this comment.
Using addTearDown(handle.dispose) immediately after creating the SemanticsHandle is a safer pattern. It ensures that the handle is properly disposed of even if the test fails or throws an exception, preventing leaks that could affect subsequent tests.
| final SemanticsHandle handle = tester.ensureSemantics(); | |
| final SemanticsHandle handle = tester.ensureSemantics(); | |
| addTearDown(handle.dispose); |
There was a problem hiding this comment.
| ); | ||
|
|
||
| semantics.dispose(); | ||
| handle.dispose(); |
There was a problem hiding this comment.
Since addTearDown(handle.dispose) is used to manage the lifecycle of the SemanticsHandle, this manual call to handle.dispose() can be removed.
There was a problem hiding this comment.
Part of flutter/flutter#182636 and flutter/flutter#188395
This PR:
widgets/semantics_tester.dart. ReplacedSemanticsTesterwithSemanticsHandle.@Skipannotation, all tests in this file has passed.semantics_tester.darthas existed incupertino_ui, so we can directly importsemantics_tester.dart;test/folder.Pre-Review Checklist
[shared_preferences]///).