[material_ui] Enable bottom_navigation_bar_test#12005
Merged
elliette merged 4 commits intoJun 25, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the skip annotation from bottom_navigation_bar_test.dart, moves feedback_tester.dart to the local test directory, and extracts the findByTooltip helper function into a shared finders.dart file to be used by both bottom navigation and navigation bar tests. Feedback on the changes suggests removing a commented-out line in finders.dart and refactoring the tooltip message extraction to be more null-safe, preventing potential runtime crashes when both message and richMessage are null.
This was referenced Jun 25, 2026
This was referenced Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port over
bottom_navigation_bar_testfrom flutter/flutter#184279feedback_tester.dartbottom_navigation_bar_testAs part of this change, moved
_findByTooltip(originally defined innavigation_bar_test) into new sharedtest/finders.dart(see flutter/flutter#186966 for details).Work towards flutter/flutter#182636 and flutter/flutter#188395
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2