Skip to content

[material_ui] Remove widgets/ import in flexible_space_bar_test.dart, app_bar_sliver_test.dart and partial fix in chip_test.dart#12004

Merged
auto-submit[bot] merged 1 commit into
flutter:mainfrom
QuncCccccc:enable_flexible_space_app_bar_sliver_tests
Jun 25, 2026
Merged

[material_ui] Remove widgets/ import in flexible_space_bar_test.dart, app_bar_sliver_test.dart and partial fix in chip_test.dart#12004
auto-submit[bot] merged 1 commit into
flutter:mainfrom
QuncCccccc:enable_flexible_space_app_bar_sliver_tests

Conversation

@QuncCccccc

@QuncCccccc QuncCccccc commented Jun 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Part of flutter/flutter#182636 and flutter/flutter#188395

This PR:

  • Removed the cross-import of widgets/semantics_tester.dart.
  • Removed @Skip tag, all tests in this file has passed. semantics_tester.dart has existed in material_ui, so we can directly import semantics_tester.dart;
  • Moved the file to test/ folder.

Note: chip_test.dart only partially remove the widgets/ dependency and still stay in temporarily_disabled_tests folder. Once flutter/flutter#184279 is ported over, this file can be move out of the folder.

Pre-Review Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter].
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I followed [the version and CHANGELOG instructions], using [semantic versioning] and the [repository CHANGELOG style], or I have commented below to indicate which documented exception this PR falls under[^1].
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jun 25, 2026
@github-actions github-actions Bot added triage-framework Should be looked at in framework triage p: material_ui labels Jun 25, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jun 25, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the @Skip annotations from app_bar_sliver_test.dart and flexible_space_bar_test.dart, updates the import path for semantics_tester.dart, and reorders the imports in both files. Additionally, the Navigator.push call in app_bar_sliver_test.dart is wrapped with unawaited. There are no review comments, and I have no feedback to provide.

@QuncCccccc QuncCccccc mentioned this pull request Jun 25, 2026
Open
@QuncCccccc QuncCccccc force-pushed the enable_flexible_space_app_bar_sliver_tests branch from 8b51276 to e111db9 Compare June 25, 2026 20:49
@github-actions github-actions Bot removed the CICD Run CI/CD label Jun 25, 2026
@QuncCccccc QuncCccccc changed the title [material_ui] Remove widgets/ import in flexible_space_bar_test.dart and app_bar_sliver_test.dart [material_ui] Remove widgets/ import in flexible_space_bar_test.dart, app_bar_sliver_test.dart and partial fix in chip_test.dart Jun 25, 2026
@QuncCccccc QuncCccccc added the CICD Run CI/CD label Jun 25, 2026
@QuncCccccc QuncCccccc changed the title [material_ui] Remove widgets/ import in flexible_space_bar_test.dart, app_bar_sliver_test.dart and partial fix in chip_test.dart [material_ui] Remove widgets/ import in flexible_space_bar_test.dart, app_bar_sliver_test.dart and partial fix in chip_test.dart Jun 25, 2026
@QuncCccccc QuncCccccc requested review from Piinks and justinmc June 25, 2026 20:56
Piinks
Piinks reviewed Jun 25, 2026
View reviewed changes
Comment thread packages/material_ui/temporarily_disabled_tests/chip_test.dart
import 'package:flutter_test/flutter_test.dart';

import '../widgets/feedback_tester.dart';
import '../widgets/semantics_tester.dart';

@Piinks Piinks Jun 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this move out of the temp disabled directory?

@QuncCccccc QuncCccccc Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we still need to port the feedback_tester change flutter/flutter#184279. After that, this test can be enabled.

@Piinks Piinks Jun 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha!

Piinks
Piinks approved these changes Jun 25, 2026
View reviewed changes

@Piinks Piinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 25, 2026
@auto-submit auto-submit Bot merged commit 6ca02e8 into flutter:main Jun 25, 2026
89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes
@justinmc justinmc Awaiting requested review from justinmc
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD p: material_ui triage-framework Should be looked at in framework triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@QuncCccccc @Piinks