Skip to content

[material_ui] Remove widgets import in dialog_test.dart, dropdown_menu_test.dart and sliver_app_bar_test.dart#12002

Open
QuncCccccc wants to merge 1 commit into
flutter:mainfrom
QuncCccccc:enable_dialog_sliver_dropdown_menu_tests
Open

[material_ui] Remove widgets import in dialog_test.dart, dropdown_menu_test.dart and sliver_app_bar_test.dart#12002
QuncCccccc wants to merge 1 commit into
flutter:mainfrom
QuncCccccc:enable_dialog_sliver_dropdown_menu_tests

Conversation

@QuncCccccc

Copy link
Copy Markdown
Contributor

Part of flutter/flutter#182636 and flutter/flutter#188395

This PR:

  • Removed the cross-import of widgets/semantics_tester.dart.
  • Removed @Skip tag, all tests in this file has passed. semantics_tester.dart has existed in material_ui, so we can directly import semantics_tester.dart;
  • Moved the file to test/ folder.

Pre-Review Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter].
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I followed [the version and CHANGELOG instructions], using [semantic versioning] and the [repository CHANGELOG style], or I have commented below to indicate which documented exception this PR falls under[^1].
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jun 25, 2026
@github-actions github-actions Bot added triage-framework Should be looked at in framework triage p: material_ui labels Jun 25, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the @Skip annotations from dialog_test.dart, dropdown_menu_test.dart, and sliver_app_bar_test.dart to re-enable these test files. It also updates import paths, reorders imports, and wraps several asynchronous dialog-showing functions in unawaited calls in dialog_test.dart. There are no review comments, so I have no feedback to provide.

@QuncCccccc

Copy link
Copy Markdown
Contributor Author

Used unawaited because of the same reason as #12001 (comment).

@QuncCccccc QuncCccccc force-pushed the enable_dialog_sliver_dropdown_menu_tests branch from f4aa3bc to e70deeb Compare June 25, 2026 20:24
@github-actions github-actions Bot removed the CICD Run CI/CD label Jun 25, 2026
@QuncCccccc QuncCccccc added the CICD Run CI/CD label Jun 25, 2026

@chunhtai chunhtai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD p: material_ui triage-framework Should be looked at in framework triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants