[material_ui] Remove widgets import in dialog_test.dart, dropdown_menu_test.dart and sliver_app_bar_test.dart#12002
Open
QuncCccccc wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the @Skip annotations from dialog_test.dart, dropdown_menu_test.dart, and sliver_app_bar_test.dart to re-enable these test files. It also updates import paths, reorders imports, and wraps several asynchronous dialog-showing functions in unawaited calls in dialog_test.dart. There are no review comments, so I have no feedback to provide.
Contributor
Author
|
Used |
f4aa3bc to
e70deeb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of flutter/flutter#182636 and flutter/flutter#188395
This PR:
widgets/semantics_tester.dart.semantics_tester.darthas existed in material_ui, so we can directly importsemantics_tester.dart;test/folder.Pre-Review Checklist
[shared_preferences]///).