[material_ui] Remove widgets import in bottom_sheet_test.dart#12001
Open
QuncCccccc wants to merge 1 commit into
Open
[material_ui] Remove widgets import in bottom_sheet_test.dart#12001QuncCccccc wants to merge 1 commit into
bottom_sheet_test.dart#12001QuncCccccc wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the @Skip annotation from packages/material_ui/test/bottom_sheet_test.dart and wraps multiple asynchronous calls to showModalBottomSheet and showBottomSheet inside unawaited to properly handle their returned futures. Additionally, it cleans up and reorders the imports in the test file. There are no review comments, and I have no feedback to provide.
QuncCccccc
commented
Jun 25, 2026
| @Skip( | ||
| 'This file is skipped due to a cross-import that needs to be fixed. Tracked in https://github.com/flutter/flutter/issues/177028.', | ||
| ) | ||
| import 'dart:async' show unawaited; |
Contributor
Author
There was a problem hiding this comment.
Used unawaited to fix error
info - test/bottom_sheet_test.dart:78:7 - Missing an 'await' for the 'Future' computed by this expression. Try adding an 'await' or wrapping the expression with 'unawaited'. -
unawaited_futures
info - test/bottom_sheet_test.dart:117:10 - Missing an 'await' for the 'Future' computed by this expression. Try adding an 'await' or wrapping the expression with 'unawaited'. -
unawaited_futures
20f1125 to
27c4774
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of flutter/flutter#182636 and flutter/flutter#188395
This PR:
widgets/semantics_tester.dart.semantics_tester.darthas existed in material_ui, so we can directly importsemantics_tester.dart;test/folder.Pre-Review Checklist
[shared_preferences]///).