[cupertino_ui] Migrate button_test.dart to SemanticsHandle#11992
[cupertino_ui] Migrate button_test.dart to SemanticsHandle#11992Renzo-Olivares wants to merge 1 commit into
button_test.dart to SemanticsHandle#11992Conversation
There was a problem hiding this comment.
Code Review
This pull request removes a skip annotation from button_test.dart and refactors the Cupertino button semantics test to use standard Flutter semantics testing utilities instead of a custom helper. The review feedback suggests using addTearDown to ensure the SemanticsHandle is properly disposed of even if assertions fail, allowing the manual disposal call to be removed.
|
|
||
| testWidgets('Cupertino button is semantically a button', (WidgetTester tester) async { | ||
| final semantics = SemanticsTester(tester); | ||
| final SemanticsHandle handle = tester.ensureSemantics(); |
There was a problem hiding this comment.
To ensure that the SemanticsHandle is always disposed of, even if an assertion/expectation fails during the test, it is recommended to use addTearDown(handle.dispose) immediately after creating it.
| final SemanticsHandle handle = tester.ensureSemantics(); | |
| final SemanticsHandle handle = tester.ensureSemantics(); | |
| addTearDown(handle.dispose); |
There was a problem hiding this comment.
This is how the test was previously structured, no addTearDown was previously used. Also explanation from gemini below as to why the test fails if we do use addTearDown(handle.dispose).
From gemini:
Flutter's TestWidgetsFlutterBinding runs its end-of-test leak verifications (specifically _verifySemanticsHandlesWereDisposed) inside the test body execution flow, immediately after your test callback completes, but before returning control to the Dart test runner:
1. [Test Runner] Starts test
2. [Flutter Binding] Runs test body (your async callback)
3. Your test code executes...
4. Your test code completes.
5. [Flutter Binding] Runs _endOfTestVerifications() <-- CRITICAL POINT
6. Checking active SemanticsHandles...
ERROR: "A SemanticsHandle was active at the end of the test."
7. [Test Runner] Runs addTearDown callbacks <-- TOO LATE!
8. handle.dispose() is called here.
Because the verification (Step 5) happens before the test runner runs the teardown callbacks (Step 7), the binding sees that the SemanticsHandle is still active and throws a FlutterError, failing the test.
| ); | ||
|
|
||
| semantics.dispose(); | ||
| handle.dispose(); |
There was a problem hiding this comment.
Since addTearDown(handle.dispose) is now used to clean up the SemanticsHandle, this manual call to handle.dispose() can be removed.
There was a problem hiding this comment.
Part of flutter/flutter#182636 and flutter/flutter#188395
This PR:
widgets/semantics_tester.dart. ReplacedSemanticsTesterwithSemanticsHandle.@Skipannotation, all tests in this file has passed.semantics_tester.darthas existed incupertino_ui, so we can directly importsemantics_tester.dart;test/folder.Pre-Review Checklist
[shared_preferences]///).