[cupertino_ui] Migrate radio_test.dart to SemanticsHandle#11981
[cupertino_ui] Migrate radio_test.dart to SemanticsHandle#11981Renzo-Olivares wants to merge 3 commits into
radio_test.dart to SemanticsHandle#11981Conversation
radio_test.dart to SemanticsHandleradio_test.dart to SemanticsHandle
There was a problem hiding this comment.
Code Review
This pull request removes the @Skip annotation from radio_test.dart, removes the import of semantics_tester.dart, and refactors the tests to use tester.ensureSemantics() and isSemantics assertions instead of SemanticsTester. The feedback suggests using addTearDown(handle.dispose) immediately after creating the SemanticsHandle to ensure it is always disposed of, and removing the manual handle.dispose() calls.
|
|
||
| testWidgets('Radio selected semantics - platform adaptive', (WidgetTester tester) async { | ||
| final semantics = SemanticsTester(tester); | ||
| final SemanticsHandle handle = tester.ensureSemantics(); |
There was a problem hiding this comment.
Using addTearDown(handle.dispose) immediately after tester.ensureSemantics() is recommended to ensure that the SemanticsHandle is always disposed of, even if the test fails or throws an exception before reaching the end of the test.
final SemanticsHandle handle = tester.ensureSemantics();
addTearDown(handle.dispose);There was a problem hiding this comment.
This is how the test was previously structured, no addTearDown was previously used. Also explanation from gemini below as to why the test fails if we do use addTearDown(handle.dispose).
From gemini:
Flutter's TestWidgetsFlutterBinding runs its end-of-test leak verifications (specifically _verifySemanticsHandlesWereDisposed) inside the test body execution flow, immediately after your test callback completes, but before returning control to the Dart test runner:
1. [Test Runner] Starts test
2. [Flutter Binding] Runs test body (your async callback)
3. Your test code executes...
4. Your test code completes.
5. [Flutter Binding] Runs _endOfTestVerifications() <-- CRITICAL POINT
6. Checking active SemanticsHandles...
ERROR: "A SemanticsHandle was active at the end of the test."
7. [Test Runner] Runs addTearDown callbacks <-- TOO LATE!
8. handle.dispose() is called here.
Because the verification (Step 5) happens before the test runner runs the teardown callbacks (Step 7), the binding sees that the SemanticsHandle is still active and throws a FlutterError, failing the test.
| ), | ||
| ); | ||
|
|
||
| handle.dispose(); |
There was a problem hiding this comment.
Since addTearDown(handle.dispose) is used to automatically dispose of the SemanticsHandle at the end of the test, this manual call to handle.dispose() can be removed.
There was a problem hiding this comment.
|
|
||
| testWidgets('Radio semantics', (WidgetTester tester) async { | ||
| final semantics = SemanticsTester(tester); | ||
| final SemanticsHandle handle = tester.ensureSemantics(); |
There was a problem hiding this comment.
Using addTearDown(handle.dispose) immediately after tester.ensureSemantics() is recommended to ensure that the SemanticsHandle is always disposed of, even if the test fails or throws an exception before reaching the end of the test.
final SemanticsHandle handle = tester.ensureSemantics();
addTearDown(handle.dispose);There was a problem hiding this comment.
| ); | ||
|
|
||
| semantics.dispose(); | ||
| handle.dispose(); |
There was a problem hiding this comment.
Since addTearDown(handle.dispose) is used to automatically dispose of the SemanticsHandle at the end of the test, this manual call to handle.dispose() can be removed.
There was a problem hiding this comment.
|
|
||
| testWidgets('has semantic events', (WidgetTester tester) async { | ||
| final semantics = SemanticsTester(tester); | ||
| final SemanticsHandle handle = tester.ensureSemantics(); |
There was a problem hiding this comment.
Using addTearDown(handle.dispose) immediately after tester.ensureSemantics() is recommended to ensure that the SemanticsHandle is always disposed of, even if the test fails or throws an exception before reaching the end of the test.
final SemanticsHandle handle = tester.ensureSemantics();
addTearDown(handle.dispose);There was a problem hiding this comment.
| expect(object.debugSemantics!.getSemanticsData().hasAction(SemanticsAction.tap), true); | ||
|
|
||
| semantics.dispose(); | ||
| handle.dispose(); |
There was a problem hiding this comment.
Since addTearDown(handle.dispose) is used to automatically dispose of the SemanticsHandle at the end of the test, this manual call to handle.dispose() can be removed.
There was a problem hiding this comment.
radio_test.dart to SemanticsHandleradio_test.dart to SemanticsHandle
This reverts commit ccdef49.
Part of flutter/flutter#182636 and flutter/flutter#188395
This PR:
widgets/semantics_tester.dart. ReplacedSemanticsTesterwithSemanticsHandle.@Skipannotation, all tests in this file has passed.semantics_tester.darthas existed incupertino_ui, so we can directly importsemantics_tester.dart;test/folder.Pre-Review Checklist
[shared_preferences]///).