Skip to content

[material_ui] Remove widgets import in scaffold_test.dart#11973

Merged
auto-submit[bot] merged 3 commits into
flutter:mainfrom
QuncCccccc:remove_widgets_import_in_scaffold_test
Jun 25, 2026
Merged

[material_ui] Remove widgets import in scaffold_test.dart#11973
auto-submit[bot] merged 3 commits into
flutter:mainfrom
QuncCccccc:remove_widgets_import_in_scaffold_test

Conversation

@QuncCccccc

@QuncCccccc QuncCccccc commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Part of flutter/flutter#182636 and flutter/flutter#188395

This PR:

  • Removed the cross-import of semantics_tester.dart from material_ui/temporarily_disabled_tests/scaffold_test.dart.
  • Removed @Skip tag, all tests in this file has passed. semantics_tester.dart has existed in material_ui, so we can directly import ../test/semantics_tester.dart';
  • Moved the file to test/ folder.

Pre-Review Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter].
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I followed [the version and CHANGELOG instructions], using [semantic versioning] and the [repository CHANGELOG style], or I have commented below to indicate which documented exception this PR falls under[^1].
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jun 24, 2026
@QuncCccccc QuncCccccc requested a review from justinmc June 24, 2026 22:06
@github-actions github-actions Bot added triage-framework Should be looked at in framework triage p: material_ui labels Jun 24, 2026
@QuncCccccc QuncCccccc requested a review from chunhtai June 24, 2026 22:06
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jun 24, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the @Skip annotation from scaffold_test.dart to re-enable the test file, updates the import path for semantics_tester.dart, and reorders the package imports. There are no review comments, and there is no feedback to provide.

@QuncCccccc QuncCccccc mentioned this pull request Jun 24, 2026
Open
@github-actions github-actions Bot removed the CICD Run CI/CD label Jun 24, 2026
@QuncCccccc QuncCccccc added the CICD Run CI/CD label Jun 24, 2026
chunhtai
chunhtai approved these changes Jun 25, 2026
View reviewed changes

@chunhtai chunhtai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a comment

Comment thread packages/material_ui/test/scaffold_test.dart
await tester.pumpWidget(MaterialApp(routes: routes));

Navigator.pushNamed(rootKey.currentContext!, '/scaffold');
unawaited(Navigator.pushNamed(rootKey.currentContext!, '/scaffold'));

@chunhtai chunhtai Jun 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a warning for this change?

@chunhtai chunhtai Jun 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel we should remove the unawaited here just to make our coding style in sync.

@Piinks Piinks Jun 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be required. I think it was staged in flutter/flutter and waiting on the code freeze. The lint might be enabled in flutter/packages, where it's still pending in flutter/flutter. flutter/flutter#168555

@QuncCccccc QuncCccccc Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there was 2 failures in linux_analyze_stable test if we don't remove it.

@Piinks Piinks changed the title [Decoupling] Remove widgets import in scaffold_test.dart [material_ui] Remove widgets import in scaffold_test.dart Jun 25, 2026
Piinks
Piinks approved these changes Jun 25, 2026
View reviewed changes

@Piinks Piinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks Piinks added CICD Run CI/CD autosubmit Merge PR when tree becomes green via auto submit App and removed CICD Run CI/CD labels Jun 25, 2026
@auto-submit auto-submit Bot merged commit b762514 into flutter:main Jun 25, 2026
89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes
@chunhtai chunhtai chunhtai approved these changes
@justinmc justinmc Awaiting requested review from justinmc
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD p: material_ui triage-framework Should be looked at in framework triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@QuncCccccc @Piinks @chunhtai