Skip to content

[material_ui] Port PR (#187247) from flutter/flutter to material_ui #11971

Closed
elliette wants to merge 1 commit into
flutter:mainfrom
elliette:cp-flutter-187247
Closed

[material_ui] Port PR (#187247) from flutter/flutter to material_ui #11971
elliette wants to merge 1 commit into
flutter:mainfrom
elliette:cp-flutter-187247

Conversation

@elliette

@elliette elliette commented Jun 24, 2026

Copy link
Copy Markdown
Member

Most Material and Cupertino code was copied over from flutter/flutter in #11888, but a few PRs landed after that copy. This PR copies one of those PRs to this repo.

Ports over flutter/flutter#187247.

Work towards flutter/flutter#188441

Pre-Review Checklist

Test exemption: cherry-pick of PR from flutter/flutter

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2

@jason-simmons @elliette
Remove the Y coordinate flip workaround in the Material stretch effec…
5107cc8 
…t shader now that it is no longer required by the Impeller GLES back end (#187247)

flutter/flutter#186556 makes the behavior of the
Y axis in the GLES back end consistent with other Impeller back ends.
Shaders will render incorrectly if they continue to flip the Y axis
based on "#ifdef IMPELLER_TARGET_OPENGLES".
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jun 24, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jun 24, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the conditional compilation block for IMPELLER_TARGET_OPENGLES in stretch_effect.frag, simplifying the assignment of uv.y to out_v_norm. There are no review comments, and there is no feedback to provide.

@elliette elliette mentioned this pull request Jun 24, 2026
Open
@github-actions github-actions Bot added triage-framework Should be looked at in framework triage p: material_ui labels Jun 24, 2026
@jason-simmons

jason-simmons commented Jun 24, 2026

Copy link
Copy Markdown
Member

@chunhtai What is the status of flutter/flutter#187807?

Should this PR be ported to material_ui as is? Or does it need to use the IMPELLER_OPENGLES_UNFLIPPED_DEPRECATED macro for compatibility with both older and current engines?

@chunhtai

chunhtai commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Hi @jason-simmons after some investigation, the shader was sideloaded from flutter_tool with hardcoded file path, which mean it will use the flutter/flutter's shader file and ignore the version in material_ui. I think we won't need the migration for now.

I am currently working on keeping the stretch shader to be permanently in flutter/flutter flutter/flutter#187960, I am still trying to figure out if there is something i missed before i can land the pr. If that PR lands, we don't need the IMPELLER_OPENGLES_UNFLIPPED_DEPRECATED migration anymore

@Piinks Piinks changed the title [Decoupling] Port PR (#187247) from flutter/flutter to material_ui [material_ui] Port PR (#187247) from flutter/flutter to material_ui Jun 25, 2026
@elliette

elliette commented Jun 25, 2026

Copy link
Copy Markdown
Member Author

Closing, this will be handled by flutter/flutter#188526

@elliette elliette closed this Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc Awaiting requested review from justinmc
@jason-simmons jason-simmons Awaiting requested review from jason-simmons
1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CICD Run CI/CD p: material_ui triage-framework Should be looked at in framework triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@elliette @jason-simmons @chunhtai