[local_auth_darwin] Migrate XCTest to Swift Testing #10802

jmagman · 2026-01-15T05:23:55Z

◇ Test run started.
↳ Testing Library Version: 102 (arm64-apple-ios13.0-simulator)
◇ Suite LocalAuthPluginTests started.
◇ Test failedAuthWithEvaluateError(errorCode:expectedResult:expectBiometrics:) started.
◇ Test getEnrolledBiometricsWithTouchID() started.
◇ Test successfullAuthWithBiometrics() started.
◇ Test deviceSupportsBiometrics_withEnrolledHardware() started.
◇ Test deviceSupportsBiometrics_withBiometryNotAvailable() started.
◇ Test deviceSupportsBiometrics_withNonEnrolledHardware() started.
◇ Test failedAuthWithCanEvaluateError(error:expectedResult:) started.
◇ Test localizedFallbackTitle() started.
◇ Test deviceSupportsBiometrics_withBiometryNotAvailableWhenPermissionsDenied() started.
◇ Test successfullAuthWithoutBiometrics() started.
◇ Test getEnrolledBiometricsWithoutEnrolledHardware() started.
◇ Test skippedLocalizedFallbackTitle() started.
◇ Test isDeviceSupportedHandlesSupported() started.
◇ Passing 3 arguments errorCode → -9, expectedResult → .appCancel, expectBiometrics → false to failedAuthWithEvaluateError(errorCode:expectedResult:expectBiometrics:)
◇ Test getEnrolledBiometricsWithFaceID() started.
◇ Passing 3 arguments errorCode → -1, expectedResult → .authenticationFailed, expectBiometrics → true to failedAuthWithEvaluateError(errorCode:expectedResult:expectBiometrics:)
◇ Passing 3 arguments errorCode → -4, expectedResult → .systemCancel, expectBiometrics → false to failedAuthWithEvaluateError(errorCode:expectedResult:expectBiometrics:)
◇ Passing 3 arguments errorCode → 99, expectedResult → .unknownError, expectBiometrics → false to failedAuthWithEvaluateError(errorCode:expectedResult:expectBiometrics:)
◇ Passing 3 arguments errorCode → -2, expectedResult → .userCancel, expectBiometrics → false to failedAuthWithEvaluateError(errorCode:expectedResult:expectBiometrics:)
◇ Passing 3 arguments errorCode → -3, expectedResult → .userFallback, expectBiometrics → false to failedAuthWithEvaluateError(errorCode:expectedResult:expectBiometrics:)
◇ Passing 3 arguments errorCode → -1, expectedResult → .authenticationFailed, expectBiometrics → false to failedAuthWithEvaluateError(errorCode:expectedResult:expectBiometrics:)
◇ Passing 2 arguments error → LAError(rawValue: -8), expectedResult → .biometryLockout to failedAuthWithCanEvaluateError(error:expectedResult:)
◇ Passing 2 arguments error → LAError(rawValue: -6), expectedResult → .biometryNotAvailable to failedAuthWithCanEvaluateError(error:expectedResult:)
◇ Test isDeviceSupportedHandlesUnsupported() started.
◇ Passing 2 arguments error → LAError(rawValue: -7), expectedResult → .biometryNotEnrolled to failedAuthWithCanEvaluateError(error:expectedResult:)
◇ Passing 2 arguments error → LAError(rawValue: -10), expectedResult → .invalidContext to failedAuthWithCanEvaluateError(error:expectedResult:)
◇ Passing 2 arguments error → LAError(rawValue: -5), expectedResult → .passcodeNotSet to failedAuthWithCanEvaluateError(error:expectedResult:)
◇ Passing 2 arguments error → LAError(rawValue: -1004), expectedResult → .notInteractive to failedAuthWithCanEvaluateError(error:expectedResult:)
✔ Test getEnrolledBiometricsWithTouchID() passed after 0.041 seconds.
✔ Test deviceSupportsBiometrics_withBiometryNotAvailable() passed after 0.041 seconds.
✔ Test deviceSupportsBiometrics_withBiometryNotAvailableWhenPermissionsDenied() passed after 0.041 seconds.
✔ Test deviceSupportsBiometrics_withNonEnrolledHardware() passed after 0.041 seconds.
✔ Test isDeviceSupportedHandlesSupported() passed after 0.041 seconds.
✔ Test getEnrolledBiometricsWithoutEnrolledHardware() passed after 0.041 seconds.
✔ Test deviceSupportsBiometrics_withEnrolledHardware() passed after 0.041 seconds.
✔ Test failedAuthWithCanEvaluateError(error:expectedResult:) passed after 0.041 seconds.
✔ Test getEnrolledBiometricsWithFaceID() passed after 0.041 seconds.
✔ Test successfullAuthWithBiometrics() passed after 0.041 seconds.
✔ Test isDeviceSupportedHandlesUnsupported() passed after 0.002 seconds.
✔ Test successfullAuthWithoutBiometrics() passed after 0.042 seconds.
✔ Test failedAuthWithEvaluateError(errorCode:expectedResult:expectBiometrics:) passed after 0.042 seconds.
✔ Test skippedLocalizedFallbackTitle() passed after 0.042 seconds.
✔ Test localizedFallbackTitle() passed after 0.042 seconds.
✔ Suite LocalAuthPluginTests passed after 0.042 seconds.
✔ Test run with 15 tests passed after 0.042 seconds.

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8692498766458966161/+/u/Run_package_tests/native_test/stdout

Adding CHANGELOG override per #10761 (comment)

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩² ↩³

jmagman · 2026-01-16T19:30:15Z

packages/local_auth/local_auth_darwin/darwin/Tests/FLALocalAuthPluginTests.swift

-  @MainActor
-  func testFailedAuthWithErrorBiometricLockout() {
+  @Test(arguments: [
+    (LAError.biometryLockout, AuthResult.biometryLockout),


Satisfying.

gemini-code-assist

Code Review

This pull request successfully migrates the local_auth_darwin tests from XCTest to the new Swift Testing framework. The changes are well-executed, leveraging modern features like parameterized tests with @Test(arguments:) to significantly reduce boilerplate and improve test clarity. The adoption of async/await with withCheckedContinuation for handling asynchronous callbacks is also a great improvement. I've left a couple of minor suggestions to fix typos in test function names. Overall, this is an excellent modernization of the test suite.

gemini-code-assist · 2026-01-16T20:32:30Z

packages/local_auth/local_auth_darwin/darwin/Tests/FLALocalAuthPluginTests.swift

-  @MainActor
-  func testSuccessfullAuthWithBiometrics() throws {
+  @Test
+  func successfullAuthWithBiometrics() async {


There's a typo in the function name. It should be successfulAuthWithBiometrics.

Suggested change

func successfullAuthWithBiometrics() async {

func successfulAuthWithBiometrics() async {

packages/local_auth/local_auth_darwin/darwin/Tests/FLALocalAuthPluginTests.swift

LouiseHsu

The amount of lines removed 😻

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

jmagman self-assigned this Jan 15, 2026

jmagman added the override: no changelog needed Override the check requiring CHANGELOG updates for most changes label Jan 15, 2026

github-actions bot added p: local_auth platform-ios platform-macos labels Jan 15, 2026

jmagman mentioned this pull request Jan 15, 2026

Migrate iOS plugin tests from XCTest to Swift Testing flutter/flutter#180787

Open

19 tasks

[local_auth_darwin] Migrate XCTest to Swift Testing

d6a417e

jmagman commented Jan 16, 2026

View reviewed changes

jmagman changed the base branch from main to dependabot/gradle/packages/shared_preferences/shared_preferences_android/android/androidx.datastore-datastore-preferences-1.2.0 January 16, 2026 19:58

jmagman changed the base branch from dependabot/gradle/packages/shared_preferences/shared_preferences_android/android/androidx.datastore-datastore-preferences-1.2.0 to main January 16, 2026 19:58

jmagman marked this pull request as ready for review January 16, 2026 20:30

jmagman requested review from LouiseHsu and okorohelijah as code owners January 16, 2026 20:30

gemini-code-assist bot reviewed Jan 16, 2026

View reviewed changes

LouiseHsu approved these changes Jan 16, 2026

View reviewed changes

Typo

4754a16

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 16, 2026

auto-submit bot merged commit 96de64a into flutter:main Jan 16, 2026
81 checks passed

jmagman deleted the local-auth-st branch January 16, 2026 21:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[local_auth_darwin] Migrate XCTest to Swift Testing #10802

[local_auth_darwin] Migrate XCTest to Swift Testing #10802

jmagman commented Jan 15, 2026 •

edited

Loading

Uh oh!

jmagman Jan 16, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Jan 16, 2026

Uh oh!

Uh oh!

LouiseHsu left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	func successfullAuthWithBiometrics() async {
	func successfulAuthWithBiometrics() async {

[local_auth_darwin] Migrate XCTest to Swift Testing #10802

[local_auth_darwin] Migrate XCTest to Swift Testing #10802

Conversation

jmagman commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-Review Checklist

Footnotes

Uh oh!

jmagman Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

LouiseHsu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jmagman commented Jan 15, 2026 •

edited

Loading