Skip to content

[google_maps_flutter_android] Add advanced markers support #10381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jokerttu wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[google_maps_flutter_android] Add advanced markers support #10381

jokerttu wants to merge 3 commits into from

Conversation

@jokerttu
Copy link
Contributor

@jokerttu jokerttu commented Nov 7, 2025 •
edited
Loading

This PR adds Advanced markers support to the Android implementation of google_maps_flutter.
Approved combined PR: #7882
Approved and merged platform interface PR: #9737
Issue: flutter/flutter#155526

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3

@jokerttu jokerttu requested a review from reidbaker as a code owner November 7, 2025 14:49
gemini-code-assist[bot]
gemini-code-assist bot reviewed Nov 7, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for Advanced Markers in the Android implementation of google_maps_flutter. The changes are comprehensive, including dependency updates, new logic for handling AdvancedMarkerOptions like PinConfig and collisionBehavior, and the addition of AdvancedMarkerClusterRenderer for clustering. A new API, isAdvancedMarkersAvailable, is also included. The example app has been updated with new pages to demonstrate these features. The implementation is solid and well-tested. I have a couple of minor suggestions to improve code quality and maintainability.

@stuartmorgan-g stuartmorgan-g added the triage-android Should be looked at in Android triage label Nov 18, 2025
@jokerttu jokerttu mentioned this pull request Nov 19, 2025
Open
11 tasks
@jokerttu jokerttu force-pushed the feature/advanced_markers_google_maps_flutter_android branch from 44e6b7a to 3cfb6f4 Compare November 24, 2025 09:11
reidbaker
reidbaker reviewed Dec 4, 2025
View reviewed changes
Copy link
Contributor

@reidbaker reidbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Java code reviewed. Sorry this took so long but thank you so much for your contribution.

@reidbaker reidbaker requested a review from camsim99 December 4, 2025 18:24
@jokerttu jokerttu force-pushed the feature/advanced_markers_google_maps_flutter_android branch 2 times, most recently from 304d11c to 4e3e0e9 Compare December 9, 2025 14:11
@jokerttu jokerttu requested a review from reidbaker December 9, 2025 14:12
@jokerttu jokerttu force-pushed the feature/advanced_markers_google_maps_flutter_android branch from 4e3e0e9 to 82fa871 Compare December 12, 2025 10:43
@jokerttu
Copy link
Contributor Author

jokerttu commented Jan 12, 2026

Hi, any update on this?

For context:

I just wanted to check whether anything is blocking a re-review. Please let me know if there’s anything else you need from me.

camsim99
camsim99 approved these changes Jan 12, 2026
View reviewed changes
Copy link
Contributor

@camsim99 camsim99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay. This looks good to me! We'll just need a second review to get this landed at this point.

@camsim99 camsim99 requested a review from a team January 12, 2026 20:24
@jokerttu jokerttu force-pushed the feature/advanced_markers_google_maps_flutter_android branch from 82fa871 to b0ab124 Compare January 14, 2026 11:22
@jokerttu
Copy link
Contributor Author

jokerttu commented Jan 14, 2026

Rebased and tested locally. Waiting second review.

@jokerttu
Copy link
Contributor Author

jokerttu commented Jan 14, 2026 •
edited
Loading

@camsim99
Noticed that this commit has updated color handling for pigeon messaging.

Therefore I also updated new colors values for Advanced Markers to use the same mechanism on following commit: f45c208

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camsim99 camsim99 camsim99 approved these changes

@reidbaker reidbaker Awaiting requested review from reidbaker reidbaker is a code owner

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

p: google_maps_flutter platform-android triage-android Should be looked at in Android triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jokerttu @reidbaker @camsim99 @stuartmorgan-g