Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/packages
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 19ec8b861676
Choose a base ref
...
head repository: flutter/packages
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 93cbed65f336
Choose a head ref
  • 3 commits
  • 13 files changed
  • 3 contributors

Commits on May 11, 2026

  1. [ci] refactor: Cleanup tooling for handling arch build output <= Flut…

    …ter v3.13.x (#11399)
    
    There remained some code, which was left in to support build output for Flutter <= v3.16.x (see:  flutter/flutter@792e26d)
    As the minimum supported Flutter version is 3.35.x as of https://github.com/flutter/packages/blob/eab1265529a0fe75e1f800ecf96c5012be155942/.ci/targets/repo_checks.yaml#L31
    we can remove the special handling for versions prior v3.16.x.
    
    Contributes to flutter/flutter#129807
    
    ## Pre-Review Checklist
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    Gustl22 authored May 11, 2026
    Configuration menu
    Copy the full SHA
    4a6a444 View commit details
    Browse the repository at this point in the history
  2. [vector_graphics_compiler] Add modern HSL color parsing (#11657)

    ## Description
    
    Follow-up to #11619 and flutter/flutter#185833.
    
    This moves HSL/HSLA function parsing from `parser.dart` into `colors.dart`, following the existing `parseCssRgb` / `parseRgbFunction` structure. It also adds support for the same practical legacy/modern syntax split already supported for RGB:
    
    - legacy comma-separated syntax, e.g. `hsl(270, 100%, 76%)`
    - modern space-separated syntax, e.g. `hsl(270 100% 76% / 0.5)`
    
    This is intentionally scoped to the existing regex-based numeric parser style; it does not attempt to implement the full CSS Color 4 grammar.
    
    ## Tests
    
    - Added `parseCssHsl` record parser tests covering legacy syntax, modern syntax, whitespace/case variations, decimal/negative tokens, and invalid syntax.
    - Added `SvgParser.parseColor` tests for modern HSL/HSLA conversion and HSLA alpha behavior.
    - Added HSLA alpha boundary and clamp tests for `0`, `0%`, `1`, `100%`, `50%`, `-0.5`, `-10%`, `2`, and `150%`.
    
    Ran locally:
    
    ```sh
    flutter test test/colors_test.dart test/parsers_test.dart
    dart analyze lib/src/svg/colors.dart lib/src/svg/parser.dart test/colors_test.dart test/parsers_test.dart
    ```
    
    ## Related Issues
    
    Fixes flutter/flutter#186153
    fondoger authored May 11, 2026
    Configuration menu
    Copy the full SHA
    5f6dd30 View commit details
    Browse the repository at this point in the history
  3. [vector_graphics] Fix uncaught StateError in useHtmlRenderObject on C…

    …anvasKit / iOS Safari (#11685)
    
    ## Description
    
    `useHtmlRenderObject()` only caught `UnsupportedError` when probing
    `toImageSync`. CanvasKit on Mobile Safari (iOS 18.7) throws a `StateError`
    ("Unable to convert read pixels from SkImage") instead, which escapes the
    `try/catch` and crashes the widget subtree.
    
    This change treats both `UnsupportedError` and `StateError` as
    "use the HTML render object" — the function only exists to probe and
    pick a fallback.
    
    ## Related Issues
    
    Fixes flutter/flutter#186333
    
    ## Tests
    
    The failure mode is only triggered by specific CanvasKit / Mobile Safari
    combinations (observed on iOS 18.7) and cannot be reproduced deterministically
    in a unit test against the host's renderer. Validated against production
    telemetry on iOS 18.7 Safari, where this exception is currently uncaught and
    reaches users.
    
    All existing `vector_graphics` and `vector_graphics_compiler` tests still
    pass after the change.
    smihica authored May 11, 2026
    Configuration menu
    Copy the full SHA
    93cbed6 View commit details
    Browse the repository at this point in the history
Loading