Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/packages
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 17bd92e8a37d
Choose a base ref
...
head repository: flutter/packages
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 428ba3e24532
Choose a head ref
  • 2 commits
  • 36 files changed
  • 1 contributor

Commits on Nov 13, 2023

  1. [tool] Add Kotlin autoformatting (#5374) 

    Updates the tooling to fetch and use `ktfmt` for Kotlin code, the same way it currently does for the Google Java formatter, and applies that formatting (in the default mode; see discussion in the linked issue) to the repository.

In the future we could revisit the formatter or mode, but since this currently seems to be the most consistent with our other languages and to google3 formatting this is likely the option we'll want to stick with.

Fixes flutter/flutter#118756
    @stuartmorgan-g
    stuartmorgan-g authored Nov 13, 2023
    Configuration menu
    Copy the full SHA
    72de224 View commit details
    Browse the repository at this point in the history

  2. [pigeon] Remove semicolons from Kotlin generation (#5375) 

    Callback calls were generating unnecessary semicolons at the end of the line, which was inconsistent with the rest of the file and with Kotlin style in general (as highlighted by experiments with `ktfmt`).
    @stuartmorgan-g
    stuartmorgan-g authored Nov 13, 2023
    Configuration menu
    Copy the full SHA
    428ba3e View commit details
    Browse the repository at this point in the history
Loading