This repository was archived by the owner on Apr 29, 2022. It is now read-only.
Add explicit Point/Vector2 scaling methods to Matrix and Canvas #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
approved these changes
Apr 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an explicit Vector2 scale override in
MatrixandCanvas.So I ran into some confusion while adding imgui elements to the test for flutter/flutter#101330. I set the canvas scale with
canvas.Scale({3, 3}), which scaled everything correctly. However, to my dismay,canvas.GetCurrentTransformation().Invert()produced an identity matrix. The problem was thatcanvas.Scale({x, y})matchesCanvas::Scale(Vector3{x, y}), and so the Z component of the Z basis vector gets set to zero, which means the determinant ends up being zero, which makes computing the inverse nonsensical. Having this explicit override makes this mistake much less likely.(Also, drive-by fix: Move the text contents color premultiply into the render method for consistency with other contents)