Skip to content

update Web goldens #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yjbanov merged 1 commit into from
Oct 4, 2019
Merged

update Web goldens #51

yjbanov merged 1 commit into from
Oct 4, 2019

Conversation

@yjbanov
Copy link
Contributor

@yjbanov yjbanov commented Oct 4, 2019

Bulk-update all Web goldens.

@yjbanov yjbanov requested a review from ferhatb October 4, 2019 17:39
@yjbanov yjbanov mentioned this pull request Oct 4, 2019
Merged
ditman
ditman approved these changes Oct 4, 2019
View reviewed changes
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All look fairly the same to me, I wonder what's with the difference in byte size!

@ferhatb
Copy link
Contributor

ferhatb commented Oct 4, 2019

All look fairly the same to me, I wonder what's with the difference in byte size!

It looks like we made a subpixel fix related to canvas, but did not update screenshots. On 4 tests the delta is large enough on the mac platform that tests fail, on linux they pass barely.

@ditman
Copy link
Member

ditman commented Oct 4, 2019

All look fairly the same to me, I wonder what's with the difference in byte size!

It looks like we made a subpixel fix related to canvas, but did not update screenshots. On 4 tests the delta is large enough on the mac platform that tests fail, on linux they pass barely.

Very interesting. I remember trying to modify screenshots as little as possible. I guess some of them were already "old" in google3. Thanks!

@yjbanov yjbanov merged commit 17a4216 into master Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ditman ditman ditman approved these changes

+1 more reviewer

@ferhatb ferhatb ferhatb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yjbanov @ferhatb @ditman