Skip to content

Goldens for https://github.com/flutter/flutter/pull/40636 #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LongCatIsLooong merged 3 commits into from
Sep 23, 2019
Merged

Goldens for https://github.com/flutter/flutter/pull/40636 #45

LongCatIsLooong merged 3 commits into from
Sep 23, 2019

Conversation

@LongCatIsLooong
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong commented Sep 17, 2019 •
edited
Loading

flutter/flutter#40636

  • 2 new golden files
  • 3 updated goldens.

@LongCatIsLooong LongCatIsLooong changed the title goldens for Goldens for https://github.com/flutter/flutter/pull/40636 Sep 17, 2019
@LongCatIsLooong LongCatIsLooong changed the title Goldens for https://github.com/flutter/flutter/pull/40636 WIP Goldens for https://github.com/flutter/flutter/pull/40636 Sep 17, 2019
@LongCatIsLooong LongCatIsLooong changed the title WIP Goldens for https://github.com/flutter/flutter/pull/40636 Goldens for https://github.com/flutter/flutter/pull/40636 Sep 17, 2019
Piinks
Piinks approved these changes Sep 17, 2019
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LongCatIsLooong LongCatIsLooong mentioned this pull request Sep 17, 2019
Merged
9 tasks
@LongCatIsLooong LongCatIsLooong merged commit 0728c1b into flutter:master Sep 23, 2019
@LongCatIsLooong LongCatIsLooong deleted the cupertino-s-dark branch September 23, 2019 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LongCatIsLooong @Piinks