Skip to content

Conversation

@LongCatIsLooong
Copy link
Contributor

flutter/flutter#40189

the border and the font color seem to have changed

@LongCatIsLooong
Copy link
Contributor Author

LongCatIsLooong commented Sep 12, 2019

I inspected the diffs of those two images, it seems the font color didn't really change (0xFFFFFFFF) but the text regions are highlighted 🤔 .

@Piinks
Copy link
Contributor

Piinks commented Sep 12, 2019

These are brand new golden tests, correct?
My mistake, I see where they are coming from now.

Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LongCatIsLooong LongCatIsLooong merged commit ae7615c into flutter:master Sep 16, 2019
@LongCatIsLooong LongCatIsLooong deleted the nav-bar-dark-mode branch September 16, 2019 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants