Add golden images for revised cupertino switch. #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
Contributor
Author
|
(It looks like I'll need to add one more golden -- might make sense to hold off on approving until that's added to this PR) |
Contributor
|
Sounds good, I'll hold off on approving but this looks good otherwise. |
Contributor
Author
|
Awesome! Thanks for the review! N00b question: how do I request a merge? Or will that happen automatically? (I don't see any UI for merging) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes two images used to verify rendering of the revised cupertino switch widget (as per ios13 style revisions).
Pull request with code / test changes:
flutter/flutter#36087
Original issue:
flutter/flutter#33797