Skip to content
This repository was archived by the owner on Jun 13, 2024. It is now read-only.

Fixed ui bugs#931

Merged
guidezpl merged 6 commits intoflutter:mainfrom
Ahsan161815:main
Apr 20, 2023
Merged

Fixed ui bugs#931
guidezpl merged 6 commits intoflutter:mainfrom
Ahsan161815:main

Conversation

@Ahsan161815
Copy link
Copy Markdown
Contributor

Description

Fixed ui bugs #434

  1. crane - russian tabs text goes out of bounds (Fixed by making it scrollable)
  2. shrine - glow effect is not lined up with the box angle, or clipped, thus goes out of the box (see top left area of the screenshot) (Not Fixed have suggestion)
  3. settings menu - safe area at the top is not applied (Fixed)
  4. reply - back button at the top goes under the status bar (was Already Fixed)
  5. reply - bottom sheet is not scrollable (Was Already Fixed)

Tests

Please describe the tests that you added or updated to verify your changes.

Issues

  1. crane - russian tabs text goes out of bounds
  2. shrine - glow effect is not lined up with the box angle, or clipped, thus goes out of the box (see top left area of the screenshot)
  3. settings menu - safe area at the top is not applied
  4. reply - back button at the top goes under the status bar
  5. reply - bottom sheet is not scrollable

Screenshot_1681559143Screenshot_1681556066
Screenshot_1681558945
Screenshot_1681559136

@guidezpl
Copy link
Copy Markdown
Member

Please fix info • Use 'const' with the constructor to improve performance • lib/studies/crane/backdrop.dart:364:30 • prefer_const_constructors

@guidezpl
Copy link
Copy Markdown
Member

Also, what is your suggestion for the following?

| shrine - glow effect is not lined up with the box angle, or clipped, thus goes out of the box (see top left area of the screenshot) (Not Fixed have suggestion)

@Ahsan161815
Copy link
Copy Markdown
Contributor Author

Also, what is your suggestion for the following?

| shrine - glow effect is not lined up with the box angle, or clipped, thus goes out of the box (see top left area of the screenshot) (Not Fixed have suggestion)

Maybe We can use BouncingScrollPhysics() instead of default scroll behaviour. That way we don't have glow effect anymore.

@guidezpl
Copy link
Copy Markdown
Member

SGTM

@Ahsan161815
Copy link
Copy Markdown
Contributor Author

SGTM

@guidezpl I have updated the code to fix Shrine Glow effect.
below is screen recording.
shrine_glow2.webm

@guidezpl guidezpl merged commit c8872d2 into flutter:main Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants