Skip to content
This repository was archived by the owner on Jun 13, 2024. It is now read-only.

Add semantics to grid list demo#743

Merged
guidezpl merged 2 commits intoflutter:mainfrom
konainm:semantics
Aug 1, 2022
Merged

Add semantics to grid list demo#743
guidezpl merged 2 commits intoflutter:mainfrom
konainm:semantics

Conversation

@konainm
Copy link
Copy Markdown
Contributor

@konainm konainm commented Jul 27, 2022

Added semantics to the Material Grid List Component Images for better compatibility with Screen Readers

Missing Labels for Grid List Images in Material examples

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@guidezpl
Copy link
Copy Markdown
Member

Nice, please fix:

code_segments.dart is not up to date. Did you forget to run flutter pub run grinder update-code-segments?

@konainm
Copy link
Copy Markdown
Contributor Author

konainm commented Jul 31, 2022

Thanks, done!

Copy link
Copy Markdown
Member

@guidezpl guidezpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  _    ___ _____ __  __ 
 | |  / __|_   _|  \/  |
 | |_| (_ | | | | |\/| |
 |____\___| |_| |_|  |_|
                        

@guidezpl guidezpl changed the title add semantics to demo Add semantics to grid list demo Aug 1, 2022
@guidezpl guidezpl merged commit db96aac into flutter:main Aug 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants