Skip to content
This repository was archived by the owner on Jun 13, 2024. It is now read-only.
This repository was archived by the owner on Jun 13, 2024. It is now read-only.

Many routes are unconditionally using the foldable navigation strategy #904

@jonahwilliams

Description

@jonahwilliams

Existing issue?

What happened?

See also: flutter/flutter#120937

If openInSecondScreen is true, we unconditionally use a TwoPaneScreen. This is implemented as a OverlayRoute, which is typically used for popups and modal menus, so it does not hide the contents of the previous route. This leads to dramatically reduced rendering performance and no page transition, even if on a non-foldable device.

Instead the hinge check should be hoisted into route selection so that we always use a MaterialPageRoute on non-foldable devices

https://github.com/flutter/gallery/blob/main/lib/routes.dart#L133

Relevant log output

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingtriage

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions