Recognize \r as newlines from flutter #4633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacob314
reviewed
Jun 17, 2020
jacob314
reviewed
Jun 17, 2020
| @Test | ||
| public void jsonWithLineBreaks() { | ||
| final StdoutJsonParser parser = new StdoutJsonParser(); | ||
| parser.appendOutput("[{'foo':'bar'}]\ntest\n"); |
Contributor
There was a problem hiding this comment.
somewhat minor: do we have to worry about \r or \n in the middle of a json block? I don't know off the top of my head how the dart json encoder deals with them.
Member
Author
There was a problem hiding this comment.
It seems this is dealt with fine, I tried putting \r, \n and \r\n in the middle of flutter tools output and it's recognized correctly.
Contributor
|
@helin24 thanks for the ping! Dart-Code did have a similar bug (if the Flutter startup lock was held by another process, it'd fail to read the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verify that opening workbench, opening project(s), quitting, then re-opening workbench consistently results in re-opened projects having device options.
Fixes #3892