-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Fix for Ink Response Shape Differs from Parent Material in ButtonStyleButton #91849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Ink Response Shape Differs from Parent Material in ButtonStyleButton #91849
Conversation
#91844 This fixes the problem for my use case at least...
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
Gold has detected about 3 new digest(s) on patchset 1. |
|
Gold has detected about 3 new digest(s) on patchset 2. |
HansMuller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a reasonable change, but it will need a regression test.
I have taken as far as I am can then, haha. Personally, for my use case I need more gestures then the buttons allow so I will end up with a fork anyhow. |
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
@MateusAmin Thanks for the PR. Without a test I'm afraid we can't land the change, but I'll update the issue and ask if anyone would like to pick up the fix. Cheers! |
The shape the Inkwell widget takes differs from its parent Material widget leading to ink splashes that do not accurately follow the border. This fixes the problem for my use case at least...
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.