Skip to content

Add no-shuffle tag to platform_channel_test.dart #88989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Piinks merged 1 commit into from
Aug 26, 2021
Merged

Add no-shuffle tag to platform_channel_test.dart #88989

Piinks merged 1 commit into from
Aug 26, 2021

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Aug 26, 2021

This is causing the tree to be red with random seed 20210826

Fixes #88966

Will be repaired in #85160

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Aug 26, 2021
@google-cla google-cla bot added the cla: yes label Aug 26, 2021
@Piinks Piinks mentioned this pull request Aug 26, 2021
Closed
@Piinks Piinks added a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. team-infra Owned by Infrastructure team labels Aug 26, 2021
christopherfujino
christopherfujino approved these changes Aug 26, 2021
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Piinks
Copy link
Contributor Author

Piinks commented Aug 26, 2021

Merging on red to fix the tree

@Piinks Piinks merged commit 426121c into flutter:master Aug 26, 2021
@Piinks Piinks mentioned this pull request Aug 30, 2021
Open
@Swiftaxe Swiftaxe mentioned this pull request Sep 4, 2021
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog Awaiting requested review from gspencergoog

@keyonghan keyonghan Awaiting requested review from keyonghan

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels. team-infra Owned by Infrastructure team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tree is closed on many infra failures uploading metrics

2 participants

@Piinks @christopherfujino