Skip to content

Show warning when app or plugin uses the V1 Android embedding #86750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
blasten merged 3 commits into from
Jul 21, 2021
Merged

Show warning when app or plugin uses the V1 Android embedding #86750

blasten merged 3 commits into from
Jul 21, 2021

Conversation

@blasten
Copy link

@blasten blasten commented Jul 21, 2021

Fixes #84305

@blasten blasten requested review from bparrishMines and xster July 21, 2021 00:13
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jul 21, 2021
@google-cla google-cla bot added the cla: yes label Jul 21, 2021
Emmanuel Garcia added 2 commits July 20, 2021 17:16
@blasten blasten changed the title Show warning when app uses the V1 embedding or a plugin uses the V1 e… Show warning when app or plugin uses the V1 Android embedding Jul 21, 2021
bparrishMines
bparrishMines approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blasten blasten merged commit 0a8c03d into flutter:master Jul 21, 2021
@blasten blasten deleted the embedding_warning branch July 21, 2021 19:51
@jmagman jmagman mentioned this pull request Apr 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xster xster xster approved these changes

@bparrishMines bparrishMines bparrishMines approved these changes

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The tool should warn about plugins that still use the Android v1 embedding

3 participants

@blasten @xster @bparrishMines