Skip to content

Re-add liblzma as an explicit dependancy on Linux #84710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MarcusTomlinson wants to merge 2 commits into from
Closed

Re-add liblzma as an explicit dependancy on Linux #84710

MarcusTomlinson wants to merge 2 commits into from

Conversation

@MarcusTomlinson
Copy link
Contributor

@MarcusTomlinson MarcusTomlinson commented Jun 16, 2021 •
edited
Loading

(NOTE: This was fixed before, but was incorrectly reverted in #78415)

Description

If this library is missing, builds fail with:

//lib64/liblzma.so.5: undefined reference to 'pthread_sigmask@GLIBC_2.32'

NOTE: Some distros have this library installed by default (such as Ubuntu), and some do not (such as Fedora 33+).

Related Issues

Resolves: canonical/flutter-snap#17

Tests

I've updated the relative flutter-doctor tests.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 16, 2021
@google-cla google-cla bot added the cla: yes label Jun 16, 2021
This was referenced Jun 16, 2021
Closed
Merged
@stuartmorgan-g
Copy link
Contributor

stuartmorgan-g commented Jun 17, 2021

Resolves: canonical/flutter-snap#17

If this issue only happens with the snap, then doesn't that mean that reverting it was correct? It's not clear to me what makes this different. Do we have a direct include of this somewhere?

@MarcusTomlinson
Copy link
Contributor Author

MarcusTomlinson commented Jun 17, 2021

Resolves: canonical/flutter-snap#17

If this issue only happens with the snap, then doesn't that mean that reverting it was correct? It's not clear to me what makes this different. Do we have a direct include of this somewhere?

I'm so sorry! You're right, this is only snap-specific. I got misled yesterday by errors from a crusty CMakeLists.txt: canonical/ubuntu-desktop-installer@76ae8e5

Thank you for being thorough as always @stuartmorgan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Problem during flutter run (undefined reference to `pthread_sigmask@GLIBC_2.32')

2 participants

@MarcusTomlinson @stuartmorgan-g