Skip to content

Add Designed for iPad attach destination for ARM macOS #84411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Jun 14, 2021
Merged

Add Designed for iPad attach destination for ARM macOS #84411

fluttergithubbot merged 1 commit into from
Jun 14, 2021

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Jun 11, 2021 •
edited
Loading

Add a new MacOSDesignedForIPadDevice device to target when running native ARM iOS apps on Apple Silicon macOS. I called this "Mac Designed for iPad" based on the Xcode target name, since there doesn't seem to be a pithy marketing name for this feature.
Screen Shot 2021-06-10 at 10 22 49 PM

It only supports flutter attaching to iOS apps already launched from Xcode, per guidance from product leadership so as not to confuse the desktop macOS development story.

The running apps are discovered via mDNS.
Screen Shot 2021-06-10 at 9 36 26 PM

It's like a desktop device for log reading/port purposes. It's like an iOS device in that it's only supported for apps with an ios project directory. If startApp, buildApp, etc are ever implemented in a future PR, it will have to create the right structured bundle out of the iOS app.
Screen Shot 2021-06-10 at 10 26 36 PM

Also create MacOSDesignedForIPadDevices device discovery that will only return this new device type if on an ARM Mac, and iOS is supported (Xcode is installed, etc).

flutter devices does not show this device type:

$ flutter devices
No devices detected.

However when I flutter attach:

$ flutter attach --app-id "com.example.testCreate"
Syncing files to device Mac Designed for iPad...                    5.9s

Flutter run key commands.
r Hot reload. 🔥🔥🔥
...

And it's actually attached:
https://user-images.githubusercontent.com/682784/121634738-f78b9a00-ca39-11eb-9a25-b53f16dd2cda.mov

Will try to figure out a way to integration test this once #79430 is done.

flutter attach part of #66184

@jmagman jmagman added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. platform-mac Building on or for macOS specifically labels Jun 11, 2021
@jmagman jmagman self-assigned this Jun 11, 2021
@google-cla google-cla bot added the cla: no label Jun 11, 2021
@jmagman jmagman added cla: yes and removed cla: no labels Jun 11, 2021
@flutter flutter deleted a comment from google-cla bot Jun 11, 2021
jmagman
jmagman commented Jun 11, 2021
View reviewed changes
packages/flutter_tools/lib/src/macos/macos_ipad_device.dart
Comment on lines +127 to +128
/// Set to show ARM macOS as an iOS device target.
static bool allowDiscovery = false;
Copy link
Member Author

@jmagman jmagman Jun 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't figure out a non-global way to set this (modeled on FlutterTesterDevices.showFlutterTesterDevice). I tried to make it a property on a context override on IOSWorkflow but I would have needed to set it the context override only for the attach command in:

flutter/packages/flutter_tools/lib/src/runner/flutter_command_runner.dart

Lines 232 to 235 in e7b7ebc

await context.run<void>(
overrides: contextOverrides.map<Type, Generator>((Type type, dynamic value) {
return MapEntry<Type, Generator>(type, () => value);
}),

and

flutter/packages/flutter_tools/lib/src/commands/attach.dart

Lines 178 to 179 in 80668d2

Future<void> validateCommand() async {
await super.validateCommand();

and

flutter/packages/flutter_tools/lib/src/commands/attach.dart

Lines 210 to 213 in 80668d2

Future<FlutterCommandResult> runCommand() async {
await _validateArguments();
final Device device = await findTargetDevice();

Welcome suggestions to make this better.

Copy link
Contributor

@jonahwilliams jonahwilliams Jun 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

static is fine, please no more context overrides

packages/flutter_tools/test/commands.shard/hermetic/attach_test.dart
Comment on lines +62 to +64
tearDown(() {
MacOSDesignedForIPadDevices.allowDiscovery = false;
});
Copy link
Member Author

@jmagman jmagman Jun 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See allowDiscovery global comment. It's similar to:

flutter/packages/flutter_tools/test/general.shard/tester/flutter_tester_test.dart

Lines 43 to 46 in 6beafa7

group('FlutterTesterDevices', () {
tearDown(() {
FlutterTesterDevices.showFlutterTesterDevice = false;
});

@jmagman jmagman requested a review from jonahwilliams June 11, 2021 18:42
@jonahwilliams
Copy link
Contributor

jonahwilliams commented Jun 11, 2021

Heads up that I won't have a chance to look at this today since I'm heading out early, but I will take a look first thing monday

jonahwilliams
jonahwilliams approved these changes Jun 14, 2021
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit e87a85c into flutter:master Jun 14, 2021
@jmagman jmagman deleted the mac-ipad branch June 14, 2021 19:21
@jmagman jmagman mentioned this pull request Jun 14, 2021
Closed
@jmagman jmagman changed the title Add Designed by iPad attach destination for ARM macOS Add Designed for iPad attach destination for ARM macOS Jun 23, 2021
@jmagman jmagman mentioned this pull request Jun 24, 2021
Open
@jmagman jmagman added the platform-target-arm Targeting an ARM-based platform label Aug 20, 2021
@thipokch
Copy link

thipokch commented Apr 25, 2023

@jmagman Just curious if attaching from vscode would work too?

@thipokch
Copy link

thipokch commented Apr 25, 2023 •
edited
Loading

Managed to get it to work in vscode with the following config:

// (launch.json)
{
    "version": "0.2.0",
    "configurations": [
        {
            "name": "Attach: Design for iPad",
            "request": "attach",
            "type": "dart",
            "program": "lib/main.dart",
            "args": [
                "--app-id",
                "com.example"
            ],
            "deviceId": "designed-for-ipad",
        }
    ]
}

@darshankawar darshankawar mentioned this pull request May 2, 2023
Open
2 tasks
@thipokch thipokch mentioned this pull request Jun 22, 2023
Open
This was referenced Jan 10, 2024
Closed
Open
@jmagman jmagman mentioned this pull request Jan 17, 2024
Open
6 tasks
@moffatman moffatman mentioned this pull request Mar 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

platform-ios iOS applications specifically platform-mac Building on or for macOS specifically platform-target-arm Targeting an ARM-based platform tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jmagman @jonahwilliams @thipokch @fluttergithubbot