Skip to content

Run dart fix on customer tests as promised #83944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Jun 4, 2021
Merged

Run dart fix on customer tests as promised #83944

fluttergithubbot merged 1 commit into from
Jun 4, 2021

Conversation

@Hixie
Copy link
Contributor

@Hixie Hixie commented Jun 3, 2021

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jun 3, 2021
@google-cla google-cla bot added the cla: yes label Jun 3, 2021
@Hixie Hixie force-pushed the customer_tests_dart_fix branch 4 times, most recently from 73d1264 to 69fd2b4 Compare June 4, 2021 03:14
@Hixie
Copy link
Contributor Author

Hixie commented Jun 4, 2021

Blocked on flutter/tests#110.

@Hixie Hixie mentioned this pull request Jun 4, 2021
Merged
@Hixie Hixie force-pushed the customer_tests_dart_fix branch from 69fd2b4 to c553731 Compare June 4, 2021 04:59
@Hixie Hixie marked this pull request as ready for review June 4, 2021 05:58
@flutter-dashboard
Copy link

flutter-dashboard bot commented Jun 4, 2021

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

dnfield
dnfield approved these changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 0acf53e into flutter:master Jun 4, 2021
@Hixie Hixie deleted the customer_tests_dart_fix branch June 4, 2021 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Hixie @dnfield @fluttergithubbot