Add cold boot option to emulator launch command #82647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
You can write this more compactly using an if in the list literal:
final List<String> cmd = <String>[
_androidSdk.emulatorPath,
'-avd',
id,
if (cold)
'-no-snapshot-load',
];
Contributor
There was a problem hiding this comment.
nit: use a ...:
final List<String> kEmulatorLauchColdBootCommand = <String>[...kEmulatorLaunchCommand, '-no-snapshot-load'];
Contributor
There was a problem hiding this comment.
I would name this coldBoot
The cold boot option is only available for AVD.
f761845 to
41fdcf5
Compare
Contributor
Author
|
@jonahwilliams, thank you for the review. I addressed your findings in the latest commit. |
This was referenced May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cold boot option is only available for AVD.
This PR implements the following feature request: #56828
closes #56828
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.