Skip to content

[flutter_tools] support flutter run -d winuwp #82373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cbracken merged 2 commits into from
May 13, 2021
Merged

[flutter_tools] support flutter run -d winuwp #82373

cbracken merged 2 commits into from
May 13, 2021

Conversation

@cbracken
Copy link
Member

@cbracken cbracken commented May 12, 2021 •
edited
Loading

Allow flutter run to work end-to-end with a UWP device.

Uses win32/ffi for the actual launch of the application, injected via
the native API class. This is structured to avoid a g3 dependency.

Install and amuid require powershell scripts for now.

Actually connecting to the observatory requires running a command in an
elevated prompt. Instructions are presented to the user if a terminal is
attached.

Part of #82085

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cbracken
[flutter_tools] support flutter run -d winuwp
35e15be 
Allow flutter run to work end to end with a UWP device.

Uses win32/ffi for the actual launch of the application, injected via
the native API class. This is structured to avoid a g3 dependency.

Install and amuid require powershell scripts for now.

Actually connecting to the observatory requires running a command in an
elevated prompt. Instructions are presented to the user if a terminal is
attached.

This is a rebased version of
flutter#79684 by @jonahwilliams.
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 12, 2021
@google-cla google-cla bot added the cla: yes label May 12, 2021
@cbracken cbracken mentioned this pull request May 12, 2021
Closed
18 tasks
jonahwilliams
jonahwilliams approved these changes May 12, 2021
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@cbracken cbracken changed the title WIP: [flutter_tools] support flutter run -d winuwp [flutter_tools] support flutter run -d winuwp May 13, 2021
@cbracken cbracken merged commit 53c2f70 into flutter:master May 13, 2021
@cbracken cbracken deleted the winuwp_support branch May 13, 2021 03:45
@jonahwilliams jonahwilliams mentioned this pull request May 13, 2021
Closed
@liudonghua123 liudonghua123 mentioned this pull request May 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cbracken @jonahwilliams