Prevent macOS individual pod framework signing#82048
Merged
Merged
Conversation
Member
Author
|
@Hixie Request for testing exemption: on just this PR this code is not exercised in our CI setup and so isn't tested. Unfortunately this Ruby code hasn't lent itself well to unit testing, and we've relied on integration tests that actually build the macOS app and use real Apple codesigning to validate. However, when #81384 is re-landed, tests like I would just apply the #81384 patch as part of this PR to make the change and testing atomic, but I want to make sure the original contributor gets credit. |
Contributor
|
test-exempt: already tested in other PRs |
renancaraujo
approved these changes
May 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
macOS frameworks shouldn't be individually codesigned, that should instead happen when (in this case a CocoaPods script) packages the framework into the app bundle.
However, when the
PROVISIONING_PROFILE_SPECIFIERXcode build setting is passed (implemented in #81384 via the CI-friendlyFLUTTER_XCODE_PROVISIONING_PROFILE_SPECIFIERenvironment variable, and then reverted), the framework is incorrectly being signed, which causes the error:Forbid the frameworks from being individually signed.
Fixes #71613 and unblocks relanding #81384.