Skip to content

Revert "[flutter_tools] pin transitive deps during --transitive-closure" #80959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonahwilliams merged 1 commit into from
Apr 22, 2021
Merged

Revert "[flutter_tools] pin transitive deps during --transitive-closure" #80959

jonahwilliams merged 1 commit into from
Apr 22, 2021
+14 −38

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Apr 22, 2021

Reverts #80911

Broke the technical-debt benchmark:

[technical_debt__cost] [STDOUT] stdout: Downloading video_player_web 2.0.0...
[technical_debt__cost] [STDOUT] stdout: Downloading video_player_platform_interface 4.1.0...
[technical_debt__cost] [STDOUT] stdout: Downloading url_launcher_windows 2.0.0...
[technical_debt__cost] [STDOUT] stdout: Downloading url_launcher_web 2.0.0...
[technical_debt__cost] [STDOUT] stdout: Downloading url_launcher_platform_interface 2.0.2...
[technical_debt__cost] [STDOUT] stdout: Downloading url_launcher_macos 2.0.0...
[technical_debt__cost] [STDOUT] stdout: Downloading url_launcher_linux 2.0.0...
[technical_debt__cost] [STDOUT] stdout: Downloading connectivity_platform_interface 2.0.1...
[technical_debt__cost] [STDOUT] stdout: Downloading connectivity_macos 0.2.0...
[technical_debt__cost] [STDOUT] stdout: Downloading connectivity_for_web 0.4.0...
[technical_debt__cost] [STDOUT] stdout: Downloading flutter_gallery_assets 1.0.2...
[technical_debt__cost] [STDOUT] stdout: Downloading shrine_images 1.1.2...
[technical_debt__cost] [STDOUT] stdout: Downloading video_player 2.1.1...
[technical_debt__cost] [STDOUT] stdout: Downloading url_launcher 6.0.3...
[technical_debt__cost] [STDOUT] stdout: Downloading connectivity 3.0.3...
[technical_debt__cost] [STDOUT] stdout: Changed 86 dependencies!
[technical_debt__cost] [STDOUT] stderr: pub failed (65; The pubspec.lock file has changed since the .dart_tool/package_config.json file was generated, please run "pub get" again.)
[technical_debt__cost] [STDOUT] "/b/s/w/ir/k/recipe_cleanup/tmp8rHtS8/flutter sdk/bin/flutter" exit code: 65
[technical_debt__cost] [STDERR] Task failed: Executable "/b/s/w/ir/k/recipe_cleanup/tmp8rHtS8/flutter sdk/bin/flutter" failed with exit code 65.

TBR @gspencergoog

@flutter-dashboard
Copy link

flutter-dashboard bot commented Apr 22, 2021

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Apr 22, 2021
@google-cla google-cla bot added the cla: yes label Apr 22, 2021
@jonahwilliams jonahwilliams merged commit 14759dc into master Apr 22, 2021
@jonahwilliams jonahwilliams deleted the revert-80911-fix_transitive_closure_bug branch April 22, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jonahwilliams