Skip to content

Fix RenderEditable register the raw keyboard listener twice #79877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chunhtai merged 2 commits into from
Apr 6, 2021
Merged

Fix RenderEditable register the raw keyboard listener twice #79877

chunhtai merged 2 commits into from
Apr 6, 2021

Conversation

@chunhtai
Copy link
Contributor

@chunhtai chunhtai commented Apr 6, 2021

The render editable may register raw keyboard twice if it is created with hasFocus = true. This PR normalizes the raw keyboard registrations.

fixes #79818

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Apr 6, 2021
@google-cla google-cla bot added the cla: yes label Apr 6, 2021
justinmc
justinmc approved these changes Apr 6, 2021
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I'm going to check if this fixes any other similar issues.

Edit: Seems irrelevant to #78629, but I'll keep an eye out for other things this may fix.

@chunhtai chunhtai merged commit 303ce76 into flutter:master Apr 6, 2021
@SecareLupus SecareLupus mentioned this pull request Jan 2, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc approved these changes

@LongCatIsLooong LongCatIsLooong LongCatIsLooong approved these changes

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Figure out why renderEditable can be null in EditableTextState userUpdateTextEditingValue

3 participants

@chunhtai @justinmc @LongCatIsLooong