Skip to content

[flutter_releases] Flutter Stable 2.0.4 Framework Cherrypicks#79486

Merged
christopherfujino merged 2 commits into
flutter:flutter-1.26-candidate.17from
chris-forks:cherrypicks-flutter-1.26-candidate.17
Apr 1, 2021
Merged

[flutter_releases] Flutter Stable 2.0.4 Framework Cherrypicks#79486
christopherfujino merged 2 commits into
flutter:flutter-1.26-candidate.17from
chris-forks:cherrypicks-flutter-1.26-candidate.17

Conversation

@christopherfujino

@christopherfujino christopherfujino commented Mar 31, 2021

Copy link
Copy Markdown
Contributor

Scheduled Cherrypicks

Pre-submit Known Failures

  • All customer_testing shards failing as they clone from head.

Post-submit Known Failures

@flutter-dashboard flutter-dashboard Bot added a: tests "flutter test", flutter_test, or one of our tests engine flutter/engine related. See also e: labels. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Mar 31, 2021
@christopherfujino christopherfujino changed the base branch from master to flutter-1.26-candidate.17 March 31, 2021 21:49
@flutter-dashboard

Copy link
Copy Markdown

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@google-cla

google-cla Bot commented Mar 31, 2021

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla Bot added the cla: no label Mar 31, 2021
@christopherfujino christopherfujino removed the request for review from Piinks March 31, 2021 21:55
@christopherfujino

Copy link
Copy Markdown
Contributor Author

Manually overrode cla bot as the one commit author has already signed the CLA.

@kf6gpe kf6gpe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jmagman jmagman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@christopherfujino

Copy link
Copy Markdown
Contributor Author

Outstanding queued pre-submit builds are because upstream these were removed and instead their sub-builds were lifted to the top level. I will attempt to follow up with a fix (cherrypicking will be non-trivial).

@christopherfujino christopherfujino merged commit b139559 into flutter:flutter-1.26-candidate.17 Apr 1, 2021
@christopherfujino christopherfujino deleted the cherrypicks-flutter-1.26-candidate.17 branch April 1, 2021 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. engine flutter/engine related. See also e: labels. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants