Add PageController #7948
Merged
Add PageController #7948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
HansMuller
reviewed
Feb 7, 2017
Contributor
There was a problem hiding this comment.
Don't we usually make curves optional and have them default to linear?
Contributor
Author
There was a problem hiding this comment.
We do that in AnimationController, but we don't do that in ScrollController (today) because that would look ugly... Not sure what the best thing to do is.
Hixie
reviewed
Feb 7, 2017
Contributor
There was a problem hiding this comment.
add a comment in performResize to point to rereredimensions and saying that you're ignoring the return value, etc
Contributor
There was a problem hiding this comment.
also the comment here should now also mention performResize()
Hixie
reviewed
Feb 7, 2017
Contributor
There was a problem hiding this comment.
oh i see, this code moved from the other file
Hixie
reviewed
Feb 7, 2017
Contributor
There was a problem hiding this comment.
add a comment explaining the sketchiness of this line
Contributor
|
|
This patch improves PageView to the point where we can use it in the date picker. Specifically, you now get onPageChanged notifications and you can control which page is visible using a PageController.
4135e8e to
1a99bee
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch improves PageView to the point where we can use it in the date
picker. Specifically, you now get onPageChanged notifications and you can
control which page is visible using a PageController.