Skip to content

removed CIRRUS_CHANGE_MESSAGE and CIRRUS_COMMIT_MESSAGE #78761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hamdikahloun merged 2 commits into from
Apr 13, 2021
Merged

removed CIRRUS_CHANGE_MESSAGE and CIRRUS_COMMIT_MESSAGE #78761

hamdikahloun merged 2 commits into from
Apr 13, 2021

Conversation

@Abhishek01039
Copy link
Contributor

@Abhishek01039 Abhishek01039 commented Mar 22, 2021 •
edited
Loading

Now flutter uses the newer version of Gradle.
it's fixed #24935

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Mar 22, 2021
@Abhishek01039
Copy link
Contributor Author

Abhishek01039 commented Mar 22, 2021

Hello @amirh and @Hixie
can anyone please review this PR?
Thanks

@goderbauer
Copy link
Member

goderbauer commented Mar 23, 2021

@blasten
@godofredoc

@goderbauer goderbauer added c: contributor-productivity Team-specific productivity, code health, technical debt. team-infra Owned by Infrastructure team labels Mar 23, 2021
godofredoc
godofredoc approved these changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@godofredoc godofredoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hamdikahloun
hamdikahloun approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@hamdikahloun hamdikahloun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hamdikahloun hamdikahloun merged commit dba7125 into flutter:master Apr 13, 2021
@Abhishek01039 Abhishek01039 deleted the removed_cirrus_from_yml branch April 14, 2021 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hamdikahloun hamdikahloun hamdikahloun approved these changes

+2 more reviewers

@blasten blasten blasten approved these changes

@godofredoc godofredoc godofredoc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. team-infra Owned by Infrastructure team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cirrus build-apks task can blow up due to commit message

5 participants

@Abhishek01039 @goderbauer @blasten @hamdikahloun @godofredoc