-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Reland "ConstraintsTransformBox (#77994)" reverted in (#78661) #78673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reland "ConstraintsTransformBox (#77994)" reverted in (#78661) #78673
Conversation
0235292 to
69fe39e
Compare
|
Shouldn't the |
|
@Kavantix the new render object is merely a container and typically doesn't have opinions about the intrinsic size. It's possible for a particular transform to always return a tight |
|
@LongCatIsLooong So yeah indeed it should still let the child determine the intrinsic size but when asking the child it should apply the constraints, just like Padding does and like ConstrainedBox should do but still doesn’t |
|
@Kavantix Ah I see. You're right the transform matters for flow layout. Let me run this against internal tests and see if anything fails. |
a58d8a9 to
d264d3b
Compare
mdebbar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the analyzer errors!
This reverts commit c0bcb4f. Diff 69fe39e
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.