Skip to content

Conversation

@DanTup
Copy link
Contributor

@DanTup DanTup commented Feb 16, 2021

package:test has a --run-skipped flag that allows ignoring the skip attribute on tests. In VS Code I've started using this to make it easier to see whether skipped tests are passing or not without having to modify the source, though it's not currently supported for Flutter.

This PR adds the same flag to flutter test and just passes it through. The test verifies it's passed through in the same way --start-paused is.

Screenshot 2021-02-16 at 18 34 25

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@DanTup DanTup requested a review from jonahwilliams February 16, 2021 18:40
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 16, 2021
@google-cla google-cla bot added the cla: yes label Feb 16, 2021
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants