Skip to content

Widen getText support for RichText with multiple text spans in driver #75603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 3 commits into from
Feb 11, 2021
Merged

Widen getText support for RichText with multiple text spans in driver #75603

fluttergithubbot merged 3 commits into from
Feb 11, 2021

Conversation

@irundaia
Copy link
Contributor

@irundaia irundaia commented Feb 8, 2021 •
edited by goderbauer
Loading

This PR adds support for flutter_driver's getText function to return the text of a RichText composed of multiple TextSpans.

This should fix:

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Feb 8, 2021
@google-cla google-cla bot added the cla: yes label Feb 8, 2021
@irundaia irundaia force-pushed the widen_richtext_driver_support branch from 110e397 to 8cea78e Compare February 8, 2021 01:16
goderbauer
goderbauer approved these changes Feb 10, 2021
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 09fd46a into flutter:master Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

3 participants

@irundaia @goderbauer @fluttergithubbot